Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension Parameterisation (for comment, DO NOT merge!) #3

Closed
wants to merge 30 commits into from
Closed

Extension Parameterisation (for comment, DO NOT merge!) #3

wants to merge 30 commits into from

Conversation

neilsjefferies
Copy link
Member

For comment rather than commit.

@neilsjefferies
Update README.md to include parameters
3864050 
WIP
@neilsjefferies
Update README.md
a96b873
@neilsjefferies
Update README.md
bda6212
@neilsjefferies
Update README.md
2413950
@neilsjefferies
Update README.md
0272098
@neilsjefferies
Update README.md
721203e
@neilsjefferies
Update 0000-example-extension.md
51e428b
@neilsjefferies
Update 0001-digest-algorithms.md
643f95e
@neilsjefferies
Update README.md
efae56a
@neilsjefferies
Update 0001-digest-algorithms.md
6f949c3
@neilsjefferies
Update 0000-example-extension.md
bd57205
@neilsjefferies
Create 0002-N-tuple-tree.md
fa6b47c
@neilsjefferies
Update 0002-N-tuple-tree.md
06a11cc
@neilsjefferies
Update 0002-N-tuple-tree.md
9b0b183
@neilsjefferies
Update 0002-N-tuple-tree.md
cf29454
@neilsjefferies
Update README.md
9d15c12
@neilsjefferies
Update README.md
be25e2c
@neilsjefferies
Update README.md
770e6de
@neilsjefferies
Update README.md
14e16c0
@neilsjefferies
Update README.md
b6e615d
@neilsjefferies
Update 0000-example-extension.md
96a6713
@neilsjefferies
Update 0001-digest-algorithms.md
e83bfbb
@neilsjefferies
Update 0002-N-tuple-tree.md
f7ad427
@neilsjefferies
Update README.md
fd2f044
@neilsjefferies
Update 0002-N-tuple-tree.md
9849d2a
@neilsjefferies
Update 0002-N-tuple-tree.md
7df3954
@neilsjefferies
Update 0002-N-tuple-tree.md
44dbe28
@neilsjefferies
Patch 1 (#1)
be4f6ee 
* Update README.md to include parameters

WIP

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update 0000-example-extension.md

* Update 0001-digest-algorithms.md

* Update README.md

* Update 0001-digest-algorithms.md

* Update 0000-example-extension.md

* Create 0002-N-tuple-tree.md

* Update 0002-N-tuple-tree.md

* Update 0002-N-tuple-tree.md

* Update 0002-N-tuple-tree.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update 0000-example-extension.md

* Update 0001-digest-algorithms.md

* Update 0002-N-tuple-tree.md

* Update README.md

* Update 0002-N-tuple-tree.md

* Update 0002-N-tuple-tree.md

* Update 0002-N-tuple-tree.md
ahankinson
ahankinson reviewed Mar 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
pwinckles
pwinckles reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@pwinckles pwinckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some problems with n-tuple extension definition, but I thought it made sense to address those separate from the changes to how extensions are specified.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
@zimeon zimeon mentioned this pull request Apr 21, 2020
Closed
@zimeon
Copy link
Contributor

zimeon commented Apr 21, 2020

I think we'll do more work on this but I think the PR makes significant progress and will be good to get up as-is, modify with later PRs as necessary

awoods
awoods requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good. Some minor questions.

Additionally, we may want to add a Travis style validator... specifically to limit the line lengths.

docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md
* description: Indicates how many chunks are used for path generation
* type: integer
* range: 0,32
* default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving a default here may encourage consistency of approach. For example, a "tuple size" of "2" (hex characters) and a "number of tuples" of "4" provides for four billion options. That could be a reasonable default starting point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is to "pairtree" behaviour but I'm open to change.

docs/0002-N-tuple-tree.md
* type: integer
* range: 0,32
* default:
* short object root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are obviously other potential options for naming the object root. We should be open to the possibility of community feedback on that point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those can be other extensions. This is an extension based on generalising pairtree.

docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
pwinckles
pwinckles reviewed Apr 24, 2020
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
docs/0002-N-tuple-tree.md Show resolved Hide resolved
@pwinckles
Copy link
Contributor

Perhaps it would make sense to split this PR in two? One PR for the update to how extensions are defined and referenced and one for the n-tuple layout extension?

@neilsjefferies
Copy link
Member Author

Going to pick up @pwinckles suggestion and split PR's but leave this here until we've processed all the comments.

@neilsjefferies
Copy link
Member Author

Perhaps it would make sense to split this PR in two? One PR for the update to how extensions are defined and referenced and one for the n-tuple layout extension?

First part is in #8

@neilsjefferies neilsjefferies changed the title Extension Parameterisation Extension Parameterisation (for comment, DO NOT merge!) May 19, 2020
@zimeon
Copy link
Contributor

zimeon commented May 19, 2020

Replaced by #8, #9 and #10

@zimeon zimeon closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwinckles pwinckles pwinckles left review comments

@awoods awoods awoods requested changes

@zimeon zimeon zimeon approved these changes

@ahankinson ahankinson ahankinson approved these changes

@rosy1280 rosy1280 Awaiting requested review from rosy1280

@julianmorley julianmorley Awaiting requested review from julianmorley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neilsjefferies @zimeon @pwinckles @awoods @ahankinson