Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension Parameterisation (for comment, DO NOT merge!) #3
Extension Parameterisation (for comment, DO NOT merge!) #3
Changes from all commits
3864050
a96b873
bda6212
2413950
0272098
721203e
51e428b
643f95e
efae56a
6f949c3
bd57205
fa6b47c
06a11cc
9b0b183
cf29454
9d15c12
be25e2c
770e6de
14e16c0
b6e615d
96a6713
e83bfbb
f7ad427
fd2f044
9849d2a
7df3954
44dbe28
be4f6ee
e24187b
7f7d964
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving a default here may encourage consistency of approach. For example, a "tuple size" of "2" (hex characters) and a "number of tuples" of "4" provides for four billion options. That could be a reasonable default starting point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is to "pairtree" behaviour but I'm open to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are obviously other potential options for naming the object root. We should be open to the possibility of community feedback on that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those can be other extensions. This is an extension based on generalising pairtree.