Fixed: Logical paths clarification #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that logical paths must not start with reserved characters. Also adds 'and path' in the definition of logical paths.
ahankinson
requested review from
awoods,
rosy1280,
zimeon,
julianmorley and
neilsjefferies
and removed request for
awoods and
rosy1280
Updated based on @zimeon's original text.
|
I agree that the SHOULD become MUST, but before doing that I would want to hear from @julianmorley |
|
this also looks like it will close #413 |
zimeon
previously approved these changes
Mar 3, 2020
julianmorley
requested changes
Mar 3, 2020
julianmorley
reviewed
Mar 3, 2020
neilsjefferies
previously approved these changes
Mar 4, 2020
zimeon
approved these changes
Mar 4, 2020
neilsjefferies
approved these changes
Mar 4, 2020
julianmorley
approved these changes
Mar 4, 2020
awoods
approved these changes
Mar 4, 2020
rosy1280
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that logical paths must not start with reserved characters. Also adds 'and path' in the definition of logical paths.
Fixes #411
Fixes #413