Allow $filtering with enum integer value in squote and without squote #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability to convert integral value to enum member name
gathogojr
reviewed
Jul 11, 2024
src/Microsoft.OData.Core/UriParser/Binders/MetadataBindingUtils.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jul 11, 2024
src/Microsoft.OData.Core/UriParser/Binders/MetadataBindingUtils.cs
Outdated
Show resolved
Hide resolved
gathogojr
reviewed
Jul 11, 2024
gathogojr
reviewed
Jul 11, 2024
habbes
reviewed
Jul 12, 2024
src/Microsoft.OData.Core/UriParser/Binders/MetadataBindingUtils.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Jul 12, 2024
test/FunctionalTests/Microsoft.OData.Core.Tests/UriParser/Binders/MetadataBindingUtilsTests.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Jul 12, 2024
test/FunctionalTests/Microsoft.OData.Core.Tests/UriParser/Binders/MetadataBindingUtilsTests.cs
Outdated
Show resolved
Hide resolved
xuzhg
reviewed
Jul 12, 2024
| var enumMember = enumType.Members.FirstOrDefault(m => m.Value.Value == memberIntegralValue); | ||
| if (enumMember != null) | ||
| { | ||
| string literalText = ODataUriUtils.ConvertToUriLiteral(enumMember.Name, default(ODataVersion)); |
There was a problem hiding this comment.
Is it possible to use the version from configuration?
xuzhg
reviewed
Jul 12, 2024
…and adds more tests to handle float, long and int.
habbes
previously approved these changes
Jul 17, 2024
gathogojr
reviewed
Jul 19, 2024
gathogojr
reviewed
Jul 19, 2024
gathogojr
reviewed
Jul 19, 2024
gathogojr
reviewed
Jul 19, 2024
src/Microsoft.OData.Core/UriParser/Binders/MetadataBindingUtils.cs
Outdated
Show resolved
Hide resolved
WanjohiSammy
added a commit
that referenced
this pull request
Jul 22, 2024
…#3014) * Allow comparison with underlying integral for Enum member and add capability to convert integral value to enum member name * Bump with tests * Move helper methods to EnumHelper, use them to check for enum values and adds more tests to handle float, long and int. * Use explicit/exact type instead of 'var' * Add more tests to handle huge, long values * Add assertion for comparing enum member name with the result * Move extension methods from Edm EnumHelper.cs to Core in EdmExtensionMethods.cs
WanjohiSammy
added a commit
that referenced
this pull request
Jul 23, 2024
…nteger value in squote and without squote (#3018) * Support Enums as Keys in OData Client (#3013) * Checkout from 'main' * Add and modify test cases * Only allow nullable Generic Type Enum * Adding a test that throws Exception if key is nullable generic type with struct as generic argument * Adding a test to mock querying data with enum as keys * Add a test to select single entity * Add test to filter by enum member name and a test to use ByKey to filter by composite keys * Add a test to filter by enum key only using ByKey() * Allow $filtering with enum integer value in squote and without squote (#3014) * Allow comparison with underlying integral for Enum member and add capability to convert integral value to enum member name * Bump with tests * Move helper methods to EnumHelper, use them to check for enum values and adds more tests to handle float, long and int. * Use explicit/exact type instead of 'var' * Add more tests to handle huge, long values * Add assertion for comparing enum member name with the result * Move extension methods from Edm EnumHelper.cs to Core in EdmExtensionMethods.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #2542.
Description
This change is to allow
$filterusingenumintegervalue.For example, to allow:
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.