Add support for Enums as Key in OData Client and Allow $filter with integer value in squote and without squote #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checkout from 'main' * Add and modify test cases * Only allow nullable Generic Type Enum * Adding a test that throws Exception if key is nullable generic type with struct as generic argument * Adding a test to mock querying data with enum as keys * Add a test to select single entity * Add test to filter by enum member name and a test to use ByKey to filter by composite keys * Add a test to filter by enum key only using ByKey()
…#3014) * Allow comparison with underlying integral for Enum member and add capability to convert integral value to enum member name * Bump with tests * Move helper methods to EnumHelper, use them to check for enum values and adds more tests to handle float, long and int. * Use explicit/exact type instead of 'var' * Add more tests to handle huge, long values * Add assertion for comparing enum member name with the result * Move extension methods from Edm EnumHelper.cs to Core in EdmExtensionMethods.cs
habbes
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick c313eae and 3080ebc into dev-8.x branch
Checklist (Uncheck if it is not completed)