Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update eBPF/compilation instructions v8 #11278

Closed

Conversation

lukashino
Copy link
Contributor

Follow-up of #11221

Link to Redmine tickets:

Describe changes:
v8

  • minor comments from the previous PR
  • Ubuntu/Almalinux instructions are extracted to separate files and those are used in GH Actions and in the docs

v7

  • rebased on GitHub master branch

v6

  • added epel-release as recommended dependency for RPM-based systems
  • removed "Recommended" dependencies install command for both apt and dnf-based systems
  • cbindgen is installed with dnf in dnf-based systems

v5

  • inlined and shortened PATH variable edits in the RPM section
  • added minimal/recommended builds to the GH workflow from Ubuntu and Almalinux
  • added literalincludes to the docs from the Github builds
  • removed gosu from Github builds
  • added DPDK to the list of recommended dependencies

v4

  • inlined and shortened PATH variable edits in the Rust section
  • can be cloned - be added

v3

  • updates to the docs per Jeff's suggestions
  • removed the instruction to install i386 headers for the eBPF

v2

  • remove recommended configure parameters

v1

  • small edit in eBPF instructions to prefer libbpf-dev package to the cloning&compilation
  • porting changes from the improved version of installation instructions that got merged into master-6.0.x

@lukashino lukashino added the typo/doc update No code change : only doc or typo fixes label Jun 8, 2024
@lukashino lukashino requested review from jasonish, jufajardini and a team as code owners June 8, 2024 15:20
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (0d267e2) to head (61198cf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11278      +/-   ##
==========================================
- Coverage   82.99%   82.46%   -0.53%     
==========================================
  Files         942      961      +19     
  Lines      249353   251698    +2345     
==========================================
+ Hits       206952   207570     +618     
- Misses      42401    44128    +1727     
Flag Coverage Δ
fuzzcorpus 60.30% <ø> (-0.80%) ⬇️
livemode 18.69% <ø> (-0.11%) ⬇️
pcap 43.80% <ø> (-0.51%) ⬇️
suricata-verify 61.20% <ø> (-0.50%) ⬇️
unittests 59.96% <ø> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts was a rather neat solution :)
Looks good to me, seems that all the prior comments have been addressed.

@victorjulien victorjulien added this to the 8.0 milestone Jun 15, 2024
@victorjulien
Copy link
Member

Merged in #11309, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

3 participants