Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structure of EN2 snippet default-values.json #664

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

chenoya
Copy link
Contributor

@chenoya chenoya commented Sep 5, 2023

No description provided.

"contentType":"group",
"_label":"group|name|ND-Part",
"description":"Part",
"fields":[
"displayType":"GROUP",
Copy link
Contributor

@rouschr rouschr Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want "GROUP" and not "SECTION"? (same for GR-Lot)
Just to make sure before we patch everywhere ...
In the NTDs I can see things like:

"id" : "GR-Lot",
    "contentType" : "group",
    "nodeId" : "ND-Lot",
    "displayType" : "SECTION",
    "description" : "Lot related information covering Tendering Terms, Tendering Process and Purpose",
    "_label" : "group|name|ND-Lot",
    "_idScheme" : "LOT",
    "_schemeName" : "Lot",
    "_identifierFieldId" : "BT-137-Lot",
    "_repeatable" : true,
    "content" : [ {
      "id" : "BT-137-Lot",
      "contentType" : "field",
      "displayType" : "TEXTBOX",
      "description" : "Purpose Lot Identifier",
      "_label" : "field|name|BT-137-Lot",
      "_idScheme" : "LOT",
      "_schemeName" : "Lot",
      "hidden" : true
    }, {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so apparently this is on purpose for the GROUP.

Copy link
Contributor

@rouschr rouschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@rouschr rouschr merged commit e47b039 into OP-TED:develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants