Various changes for SDK 1.10 #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule BR-BT-00738-0053 already enforces that the preferred publication date must be after the dispatch date. Remove corresponding Schematron asserts.
The preferred publication date (BT-738) can now be equal to the dispatch date (BT-05). Also update corresponding schematron rules, and translations of rule message.
Allow multiple digits in SDK version number.
This notice is not about a framework contract.
This ensure the check for the presence of the field is fired even if cac:OpenTenderEvent is not present.
Add new tailored codelist "contract-term" and fix preset value of OPP-030-Tender-List.
This field was missing. Also add corresponding field for its attribute, and the schematron rules.
Update rules on when BT-105-Procedure is forbidden, and add checks on possible values based on the notice subtype. Those checks are implemented via tailored codelists. Update corresponding codelists, and schematron rules.
Also update corresponding schematron rules.
This includes all the newly added conditional forbidden/mandatory rules. Also update affected validation reports.
Under specific conditions, only CPV codes corresponding to works were allowed. Also allow CPV codes corresponding to services.
This reflects codes added and removed.
This reflects codelists added and removed.
Also add corresponding schematron rules.
Also update corresponding schematron rules, and affected validation reports.
Update affected validation reports.
This reflects the latest changes in the codelists themselves.
YvesJo
approved these changes
Oct 2, 2023
fields/fields.json
Outdated
| } ] | ||
| }, | ||
| "mandatory" : { | ||
| "value" : false, | ||
| "severity" : "ERROR", | ||
| "constraints" : [ { | ||
| "noticeTypes" : [ "1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "CEI", "T01", "T02" ], | ||
| "noticeTypes" : [ "1", "1", "2", "2", "3", "3", "4", "4", "5", "5", "6", "6", "7", "7", "8", "8", "9", "9", "10", "10", "11", "11", "12", "12", "13", "13", "14", "14", "15", "15", "16", "16", "17", "17", "18", "18", "19", "19", "20", "20", "21", "21", "22", "22", "23", "23", "24", "24", "25", "25", "26", "26", "27", "27", "28", "28", "29", "29", "30", "30", "31", "31", "32", "32", "33", "33", "34", "34", "35", "35", "36", "36", "37", "37", "38", "39", "40", "CEI", "CEI", "T01", "T01", "T02", "T02" ], |
There was a problem hiding this comment.
Notice subtypes listed twice
There was a problem hiding this comment.
Good catch, this is problem in the content of the DB, I've created a ticket for it.
There was a problem hiding this comment.
I'm merging this as-is, the diff and the number of changes in this PR are already too large.
The issue spotted here will be correct in a subsequent commit and PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.