Update dependencies on eforms-core and antlr4 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids depending on a "milestone" version.
Also update eforms-core to 1.4.0-SNAPSHOT, so that it uses the same version of antlr4, to avoid any potential problem, as parsers generated by antlr4 version 4.9 are not compatible with more recent versions.
rouschr
approved these changes
Mar 14, 2024
|
The PR for eforms-core-java has been merged, so the build is now OK. |
rousso
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the change in PR OP-TED/eforms-core-java#31, so that both libraries use the same version of Antlr4. That's because parsers generated by Antlr4 4.9 (which we used before this change) are not compatible with Antlr4 4.10 and above.
So it is expected that the build here will fail until that PR is merged.