plat-hikey: Make DRAM1_BASE configurable and replace deprecated function #6672
Conversation
There was a problem hiding this comment.
For all commits, please use your real name instead of zwb233 in S-o-b tag as per developer certificate of origin requirements.
Suggestion for commit message of "plat-hikey: Update platform_config.h to use CFG_DRAM1_BASE":
plat-hikey: Update platform_config.h to use CFG_DRAM1_BASE
-Add conditional compilation directives to lines 110-114 of
-tee4/optee_os/core/arch/arm/plat-hikey/platform_config.h
-to utilize the CFG_DRAM1_BASE configuration switch for defining DRAM1_BASE.
-This ensures that the platform configuration is consistent with the newly introduced
-configuration switch.
+Use CFG_DRAM1_BASE in core/arch/arm/plat-hikey/platform_config.h.
Signed-off-by: ...Wrap also the long lines the commit message of the last commit of the series (72 chars max)
| @@ -107,7 +107,11 @@ | |||
| #define DRAM0_BASE 0x00000000 | |||
| #define DRAM0_SIZE 0x3F000000 | |||
| #define DRAM0_SIZE_NSEC 0x3E000000 | |||
| #define DRAM1_BASE 0x40000000 | |||
| #ifdef CFG_DRAM1_BASE | |||
There was a problem hiding this comment.
As per previous commit in this series CFG_DRAM1_BASE is always defined.
There was a problem hiding this comment.
Thank you for your suggestions and review. I have made the necessary changes to the commits based on your feedback, including updating the commit names and formats, and removing unnecessary #ifdef directives.
zwb-233
force-pushed
the
master
branch
2 times, most recently
from
96f972a
to
56ede31
Compare
|
Please fix the checkpatch issues. |
zwb-233
force-pushed
the
master
branch
2 times, most recently
from
aa7220a
to
ab1b6af
Compare
I have fixed the issues, thank you. |
|
|
There was a problem hiding this comment.
Commit "plat-hikey: make DRAM1_BASE configurable":
Remove the following sentence from the commit message.
This change aligns with previous discussions and resolves issues
I think commits "plat-hikey: make DRAM1_BASE configurable" and
"plat-hikey: Update platform_config.h to use CFG_DRAM1_BASE" should be squashed into a single commit.
Commit "plat-hikey: Replace register_dynamic_shm() with register_ddr()":
The commit message doees not explain why the change is made. I would replace it with:
-The register_ddr() function is used to define RAM areas where the
-non-secure world can allocate dynamic shared memory.
-This memory can be utilized with zero-copy memory buffers passed
-as memref in TA invocations.
+Use register_ddr() instead of register_dynamic_shm() that is deprecated.Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> once addressed.
This commit introduces the CFG_DRAM1_BASE configuration switch in the plat-hikey platform. Signed-off-by: Wen Bin <a1231512a@163.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Use register_ddr() instead of register_dynamic_shm() that is deprecated. Signed-off-by: Wen Bin <a1231512a@163.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
I have merged the two commits and made the other changes you mentioned. Thank you. |
This pull request aims to enhance the plat-hikey platform configuration by introducing the CFG_DRAM1_BASE configuration switch in platform_config.h. This change enables the configuration of DRAM1_BASE and ensures platform consistency.Additionally, deprecated register_dynamic_shm() calls are replaced with register_ddr(). These modifications align with previous discussions and address issues #5146, #4768, and #6160.