Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibleFutureConnections to Schedule #4150

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

lisajulia
Copy link
Contributor

@lisajulia lisajulia commented Jul 25, 2024

Description is here: OPM/opm-simulators#5488

Copy link
Member

@blattms blattms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the PYACTION changes that are included here.

opm/input/eclipse/Schedule/Action/PyAction.cpp Outdated Show resolved Hide resolved
@lisajulia lisajulia force-pushed the fix/ACTIONX-COMPDAT branch from afa2123 to e75fde5 Compare July 29, 2024 08:16
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1199 opm-grid=742 opm-simulators=5488 please

1 similar comment
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1199 opm-grid=742 opm-simulators=5488 please

@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1200 opm-grid=742 opm-simulators=5488 please

@lisajulia
Copy link
Contributor Author

@blattms: I think this can be merged now :)

@blattms
Copy link
Member

blattms commented Jul 30, 2024

Thanks for the heads up. I just will double check that this also resolves OPM/opm-simulators#5494

@blattms
Copy link
Member

blattms commented Jul 30, 2024

Wait a minute: Jenkins checked that yesterday with "jenkins build this opm-tests=1199 opm-grid=742 opm-simulators=5488 please", right?

@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1200 opm-grid=742 opm-simulators=5488 please

and today with this

@blattms blattms merged commit 6ea038e into OPM:master Jul 30, 2024
1 check passed
@lisajulia lisajulia deleted the fix/ACTIONX-COMPDAT branch July 31, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants