Fix/actionx compdat #5488
Fix/actionx compdat #5488
Conversation
Two data files get compared: one with ACTIONX and one with the same commands but without ACTIONX. For sequential runs, they produce the same output, but for parallel runs they don't, because the when the COMPDAT keyword is used in an ACTIONX, well connections get created there that are not known to the grid partitioner.
|
jenkins build this opm-tests=1199 opm-grid=742 opm-common=4150 please |
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
2036d04 to
1654e34
Compare
|
jenkins build this opm-tests=1199 opm-grid=742 opm-common=4150 please |
1 similar comment
|
jenkins build this opm-tests=1199 opm-grid=742 opm-common=4150 please |
|
Once this is fixed, please trigger a test in the opm-common PR. That will also run the tests there. |
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
1654e34 to
8a261f0
Compare
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
8a261f0 to
efb18d0
Compare
|
According to @atgeirr we also need to take the future connections into account in BlackoilModelNldd.hpp#L944 and files opm/simulators/utils/ParallelNLDDPartitioningZoltan.*pp |
Yes, thanks, I can take care of that, but can we still merge this one and OPM/opm-tests#1199, OPM/opm-grid#742 and OPM/opm-common#4150 already? I had a brief look and I think the same approach works for NLDD and I would then open a new PR for that. |
That sounds good! It is fine to do this in two steps. |
|
This definitely makes #5494 disappear. Tested on my system. Hence, many thanks for finding and fixing this rather severe problem. |
Fix error when using the keyword COMPDAT in ACTIONX: For parallel runs, the connections opened in ACTIONX are unknown to the grid partitioner, I've added a test comparing two runs (one with actionx and one without) which fails for the current master (#5486) and also a fix which makes this test pass.
This PR depends on OPM/opm-tests#1199, OPM/opm-grid#742 and OPM/opm-common#4150 and neither of these PRs affect the reference manual.