Add possible future connections to all methods that handle the well c… #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
7284fb6 to
a09d11f
Compare
blattms
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Looks good to me.
Would be cool if we would:
- Extend the description of the PR a bit to make clear that this change is there connections that might be opened in ACTIONX and that we neglected those before.
- Add the new argument to the doxcygen docs where applicable.
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
a09d11f to
40e68af
Compare
lisajulia
force-pushed
the
fix/ACTIONX-COMPDAT
branch
from
40e68af to
457ef1c
Compare
blattms
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnections
Description is here: OPM/opm-simulators#5488