Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.citation: fix module output parameter #819

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 17, 2022

Fix module output parameter.

Current behavior

GRASS nc_spm_08_grass7/landsat:~ > g.citation v.surf.rst output=/tmp/result

GRASS nc_spm_08_grass7/landsat:~ > file /tmp/result
/tmp/result: cannot open `/tmp/result' (No such file or directory)

Expected behavior:

GRASS nc_spm_08_grass7/landsat:~ > g.citation v.surf.rst output=/tmp/result 

GRASS nc_spm_08_grass7/landsat:~ > cat /tmp/result 
@misc{v_surf_rst,
  title = {{GRASS GIS: v.surf.rst module}},
  author = {Lubos Mitas and Helena Mitasova and Irina Kosinovsky and Darrel McCauley and Jaroslav Hofierka and Stanislav Zubal and Michal Lacko},
  howpublished = {https://github.com/OSGeo/grass/tree/main/vector/v.surf.rst},
  year = {2022}
  note = {Accessed: 2022-10-16T07:02:16},
}

@tmszi tmszi added the bug Something isn't working label Oct 17, 2022
@tmszi tmszi requested a review from ninsbl October 17, 2022 03:52
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be great if you could add output to one of the tests, but no must...

@tmszi tmszi requested a review from ninsbl October 18, 2022 02:57
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests.
Tests fail with GRASS GIS 8.0 and Python 3.7, which can be expected, I guess, as 8.0 has different date formats in the manuals...
Not sure if it would be worth deactivating tests for 8.0...

@tmszi
Copy link
Member Author

tmszi commented Oct 21, 2022

Tests fail with GRASS GIS 8.0 and Python 3.7, which can be expected, I guess, as 8.0 has different date formats in the manuals... Not sure if it would be worth deactivating tests for 8.0...

The solution would be to backport this PR OSGeo/grass#2595 to the releseabranch_8_0 branch.

@ninsbl
Copy link
Member

ninsbl commented Oct 21, 2022

The solution would be to backport this PR OSGeo/grass#2595 to the releseabranch_8_0 branch.

If that is straight forward to backport 8.0 as well, that sounds reasonable...

@wenzeslaus
Copy link
Member

No need for a backport to 8.0. You can even remove 8.0 from grass-addons tests. The general policy is that we (as a project) support only the most recent release (individuals may decide to backport or even release and we may provide a limited support for that). (policy == something buried in minutes from some PSC meeting :-) please help!)

@tmszi tmszi merged commit b0ee62f into OSGeo:grass8 Oct 22, 2022
@tmszi tmszi deleted the fix-g_citation-output-param branch October 22, 2022 17:26
cwhite911 pushed a commit to cwhite911/grass-addons that referenced this pull request Sep 19, 2023
* Extend the tests to test the output parameter of the module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants