-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.citation: fix module output parameter #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Would be great if you could add output to one of the tests, but no must...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests.
Tests fail with GRASS GIS 8.0 and Python 3.7, which can be expected, I guess, as 8.0 has different date formats in the manuals...
Not sure if it would be worth deactivating tests for 8.0...
The solution would be to backport this PR OSGeo/grass#2595 to the releseabranch_8_0 branch. |
If that is straight forward to backport 8.0 as well, that sounds reasonable... |
No need for a backport to 8.0. You can even remove 8.0 from grass-addons tests. The general policy is that we (as a project) support only the most recent release (individuals may decide to backport or even release and we may provide a limited support for that). (policy == something buried in minutes from some PSC meeting :-) please help!) |
* Extend the tests to test the output parameter of the module
Fix module
output
parameter.Current behavior
Expected behavior: