Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix date and time format retrieved from the module source dir #2595

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 9, 2022

Same date and time format "%A %b %d %H:%M:%S %Y" (example Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

  1. Core modules compiled from Git repository, with date and time retrievied from the last commit.

  2. Core modules compiled from tarball without Git repository and without applied official patch core_modules_with_last_commit.patch, with date and time retrievied from the module source directory.

  3. Core modules compiled from tarball without Git repository and with applied official patch core_modules_with_last_commit.patch, with date and time retrievied from the core_modules_with_last_commit.json file.

  4. Official addons with date and time retrievied from the last commit via GitHub REST API.

  5. Unofficial addons with date and time retrievied from the module source directory.

This PR fix case no. 2 and 5.

Current date and time format (inside core module / addon man page):

Accessed: Sun Oct 9 12:16:03 2022

Expected date and time format (inside core module / addon man page):

Accessed: Sunday Oct 09 12:16:03 2022

Additional context:

After merging this PR, the g.citation addon will need to change regular expression for catch this date and time format.

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
@tmszi tmszi added the bug Something isn't working label Oct 9, 2022
@tmszi tmszi added this to the 8.2.1 milestone Oct 9, 2022
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tmszi tmszi merged commit 94b223c into OSGeo:main Oct 10, 2022
tmszi added a commit to tmszi/grass that referenced this pull request Oct 10, 2022
…SGeo#2595)

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
@tmszi tmszi deleted the fix-mkhtml-date-time-format-for-module-src-dir branch October 10, 2022 02:37
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
…SGeo#2595)

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
…SGeo#2595)

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
…SGeo#2595)

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
@wenzeslaus wenzeslaus changed the title utils: fix date and time format retrieved from the module source dir docs: Fix date and time format retrieved from the module source dir Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
…SGeo#2595)

Same date and time format `"%A %b %d %H:%M:%S %Y"` (example
Wednesday Oct 05 06:42:36 2022) inside manual page for all use cases:

1. Core modules compiled from Git repository, with date and time retrievied
from the last commit.

2. Core modules compiled from tarball without Git repository and without
applied official patch core_modules_with_last_commit.patch, with date and
time retrievied from the module source directory.

3. Core modules compiled from tarball without Git repository and with applied
official patch core_modules_with_last_commit.patch, with date and time
retrievied from the core_modules_with_last_commit.json file.

4. Official addons with date and time retrievied from the last commit
via GitHub REST API.

5. Unofficial addons with date and time retrievied from the module source
directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants