Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] r.patch: collect and apply statistics for CELL rasters with nprocs > 1 #2411

Closed
petrasovaa opened this issue May 27, 2022 · 0 comments · Fixed by #2906
Closed

[Feat] r.patch: collect and apply statistics for CELL rasters with nprocs > 1 #2411

petrasovaa opened this issue May 27, 2022 · 0 comments · Fixed by #2906
Labels
C Related code is in C enhancement New feature or request raster Related to raster data processing
Milestone

Comments

@petrasovaa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After adding OpenMP parallelization to r.patch we disabled collecting and applying statistics for CELL rasters to fix a race condition (see #2410). However there is no reason that couldn't be implemented.

Describe the solution you'd like
The fix should create an array of the stats structures for each thread and then apply them all in support function. That way threading will work together with collecting stats, so resulting CELL rasters can have the labels and colors derived from the input rasters.

@petrasovaa petrasovaa added enhancement New feature or request raster Related to raster data processing C Related code is in C labels May 27, 2022
@petrasovaa petrasovaa added this to the 8.4.0 milestone May 27, 2022
@wenzeslaus wenzeslaus modified the milestones: 8.3.0, 8.4.0 Feb 14, 2023
@petrasovaa petrasovaa linked a pull request Mar 28, 2023 that will close this issue
3 tasks
petrasovaa pushed a commit that referenced this issue May 1, 2023
neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request raster Related to raster data processing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants