r.patch: fix race condition for CELL rasters #2410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with nprocs > 1 and output CELL type, there is a race condition on line https://github.com/OSGeo/grass/blob/main/raster/r.patch/main.c#L230 (and in
do_patch
function as well). This is a quick fix that disables collecting and applying statistics from input for CELL type and nprocs > 1 (effectively activating -s flag).A proper fix should create an array of the stats structures for each thread and then apply them all in
support
function, this requires more changes.