r.patch: fix race condition for CELL rasters #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
added
bug
wenzeslaus
approved these changes
May 26, 2022
petrasovaa
added a commit
that referenced
this pull request
May 27, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
3 tasks
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with nprocs > 1 and output CELL type, there is a race condition on line https://github.com/OSGeo/grass/blob/main/raster/r.patch/main.c#L230 (and in
do_patchfunction as well). This is a quick fix that disables collecting and applying statistics from input for CELL type and nprocs > 1 (effectively activating -s flag).A proper fix should create an array of the stats structures for each thread and then apply them all in
supportfunction, this requires more changes.