-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] winGRASS 8.3.dev compilation fails with --with-openmp #2885
[Bug] winGRASS 8.3.dev compilation fails with --with-openmp #2885
Comments
|
There must be some environment difference: CI configure:
fsv.cvut.cz configure:
|
yes, there are differences CI https://github.com/OSGeo/grass/blob/main/.github/workflows/osgeo4w.yml vs. Martin's procedure: https://github.com/OSGeo/grass/blob/main/mswindows/osgeo4w/package.sh described here: https://trac.osgeo.org/grass/wiki/CompileOnWindows here I'm following Martin's procedure as daily builds and releases are built that way. I've started here just another run to post make result in the first failing |
the interesting is that both procedures are based upon the same basic environments:
|
Is clang present in either of them? |
https://www.msys2.org/docs/environments/
|
a fresh 8.3.dev checkout
|
Could you share the config.log file? |
here attached |
in pure Mingw64 shell
in a Mingw64 shell modified by the build scripts:
the needed |
Please try with deleting the line: grass/mswindows/osgeo4w/package.sh Line 136 in 4f1305d
|
find attached the config log after removing config_try_to_fix_osgeo4w_omp_issue.log configure looks now like:
CI configure (copy/paste from above):
still not the same. (no chance to compile for the moment) |
The package https://trac.osgeo.org/grass/wiki/CompileOnWindows#InstalltheMSYS2environment is a clang (llvm) package https://packages.msys2.org/base/mingw-w64-openmp. This is possibly found by configure. |
Just tested without 'mingw-w64-x86_64-openmp' package in MSYS2 env. Try again after removing the package: |
AFAIU the clang MSys2 version is installed via the LLVM OpenMP Library is the only one available in Msys2. though looking at the CI osgeo4w.yml, there is no pacman install of openmp. additionally in CI openmp is activated in configure. @ninsbl any idea why the difference? is openmp working in CI winGRASS? @landam and why it is working in winGRASS 8.2. daily builds (compiled in the same way as 8.3.dev). looking in the 8.2.daily build log there
so what have been changed between 8.2. and 8.3. regarding openmp? anyone any idea? |
did this work for you? |
Yes. :-) |
MSYS2's GCC supports OpenMP by default. The GRASS configure has been updated #2692 to detect clang (-lomp etc.), that is the only news for 8.3 (not yet backported for testing purposes). Before (and still for 8.2) 'mingw-w64-x86_64-openmp' was/is just ignored. |
To be precise, I never installed it in the first place. |
Installation:
File: looking into this file:
|
so there was a change between 8.2 and 8.3. which causes this issue. there was a reason why we added all the dll stuff in package.sh. |
after
no |
Just what we wanted. |
now configure ouputs in 8.3.dev
it seems to look ok now. @nilason thanks for helping to sort this out. @landam we have to adapt the build/compile recipes for winGRASS8.3. and if the changes should be backported to 8.2, then we have to change the recipes also there. |
Two steps need to be taken:
No 1 may be backported directly, regardless of configure backport. |
fix OSGeo#2885 for 8.3.dev
should be tackled by hopefully proper PR ;-) #2887
done |
@landam could you update your msys2 build environment by |
Done. |
fix #2885 for 8.3.dev by adapting package.sh
fix OSGeo#2885 for 8.3.dev by adapting package.sh
fix OSGeo#2885 for 8.3.dev by adapting package.sh
Describe the bug
winGRASS 8.3.dev compilation fails with --with-openmp.
I don't see this in github osgeo4w windows CI actions.
though I see it here on my win10 OSGeo4W/Msys2 winGRASS 8.3.dev build environment, and also at Martin's dailys builds.
e.g. https://wingrass.fsv.cvut.cz/grass83/logs/log-r001bf57c8b-1/error.log
first failing is always in lib/rst/interp_float
disabling by
--with-openmp=no
, compilation works.The text was updated successfully, but these errors were encountered: