-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: fix compilation --with-openmp in MS Windows #2887
Conversation
fix OSGeo#2885 for 8.3.dev
fix wingrass compilation failing in --with-openmp
anyone able to backport it then when PR is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Great to see these improvements! (would you mind to make the pull request title compliant with our release notes style? Then notes autogeneration will work much better) |
Tested on build server:
I am taking liberty to merge it. |
@hellik Is backport really needed? GRASS82 seems to be compiled successfully: https://wingrass.fsv.cvut.cz/grass82/logs/log-r1e2ac5a211-207/error.log |
See #2885 (comment) It depends If the PR mentioned in this comment will be backported or not. See also in the thread that the msys2 environment has to be adapted accordingly to avoid gcc/clang clash. I'll merge later in the evening. |
OK. |
fix OSGeo#2885 for 8.3.dev by adapting package.sh
fix OSGeo#2885 for 8.3.dev by adapting package.sh
fix #2885 by adapting package.sh