-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.pygrass: Improve exception handling in Info.open (#1555) #1559
Conversation
Bumping up milestone as 8.0.1 is due in two days, while this has not been part of RC1 and there has not been activity for some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After consulting Python documentation, I found one more issue here.
The rest of the code seems to be ready to be merged.
I merged main branch here to resolve conflict with new code on main (only a context line changed).
All right, this can be merged as is. (CI is still running now.) @Viech Two questions:
|
Likely because this MR is old and PyGRASS used that style at the time. I don't normally use
Same idea. Unless I missed something, I would've copied the style I found. Exception translation is something I don't think I've ever seen in any project, though. Users who can understand Python exceptions are very likely to understand English while users who see exceptions as gibberish will just post them in an issue and you'd end up with non-English exceptions on the tracker. |
…o#1559) * Add missing exception handling in Info.open to replace lower level and wrong exceptions. * Add additional checks. * Distinguish unsupported and unknown database drivers. Fixes OSGeo#1555.
…o#1559) * Add missing exception handling in Info.open to replace lower level and wrong exceptions. * Add additional checks. * Distinguish unsupported and unknown database drivers. Fixes OSGeo#1555.
…o#1559) * Add missing exception handling in Info.open to replace lower level and wrong exceptions. * Add additional checks. * Distinguish unsupported and unknown database drivers. Fixes OSGeo#1555.
No description provided.