Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CI error: flake8 Expected - Waiting for status to be reported #1935

Closed
neteler opened this issue Oct 10, 2021 · 4 comments
Closed

[Bug] CI error: flake8 Expected - Waiting for status to be reported #1935

neteler opened this issue Oct 10, 2021 · 4 comments
Labels
bug Something isn't working CI Continuous integration

Comments

@neteler
Copy link
Member

neteler commented Oct 10, 2021

Describe the bug
Maybe well known but I see numerous PRs failing with

flake8 Expected — Waiting for status to be reported

This happens esp. with pure C language PRs where a flake8 test doesn't make too much sense.

C related changes:

But also Python changes

It would be nice to see the flake8 test treated in a better way.

@neteler neteler added bug Something isn't working CI Continuous integration labels Oct 10, 2021
@ninsbl
Copy link
Member

ninsbl commented Oct 14, 2021

Flake8 is actually a required check, impeding merging PRs where the flake8 check is not reported as successful (even if it is). The simplest way in the github web UI I found to trigger re-run of the stale check is to close and re-open the PR:
https://stackoverflow.com/questions/52408592/how-to-relaunch-github-check-without-pushing-new-commits/52412240

@agiudiceandrea
Copy link
Contributor

@neteler @ninsbl what about #1694?

@wenzeslaus
Copy link
Member

This happens...with pure C language PRs...It would be nice to see the flake8 test treated in a better way.

One reason the test is required is a limitation of GitHub: You cannot avoid accidental pushes from local repos to the main branch in any other way than requiring a one of the test jobs to pass, but what the job actually does is not important in the context of protecting the branch. With the branch protection rule requiring a passed check, a PR is required for modifying the branch because that's the only way how to get a job running on relevant code before the actual push.

The check depends on the particular name of the job, so for old PRs, there is simply no job of that name (and that's why close/open or code update is needed to trigger new jobs).

@neteler
Copy link
Member Author

neteler commented Oct 28, 2022

Issue seems to be gone, closing.

@neteler neteler closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous integration
Projects
None yet
Development

No branches or pull requests

4 participants