Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Replace bare except by Exception in r.unpack and i.in.spotvgt #1578

Merged
merged 7 commits into from
Mar 17, 2023

Conversation

ShubhamSwati
Copy link
Contributor

I have fixed the bare except warning in the file i.in.spotvgt.py

@ShubhamSwati
Copy link
Contributor Author

I made change in another file r.unpack.py to fix bare except warning, kindly review.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs just a little cleanup, otherwise it is good to go.

scripts/.flake8 Outdated Show resolved Hide resolved
scripts/.flake8 Outdated Show resolved Hide resolved
scripts/i.in.spotvgt/i.in.spotvgt.py Outdated Show resolved Hide resolved
scripts/r.unpack/r.unpack.py Outdated Show resolved Hide resolved
scripts/r.unpack/r.unpack.py Outdated Show resolved Hide resolved
@neteler neteler added bug Something isn't working Python Related code is in Python labels Dec 9, 2021
@neteler neteler added this to the 8.0.1 milestone Dec 9, 2021
@ninsbl ninsbl modified the milestones: 8.0.1, 8.0.2 Feb 20, 2022
@ninsbl
Copy link
Member

ninsbl commented Feb 20, 2022

Bumping up milestone as 8.0.1 is due in two days, while this has not been part of RC1 and there has not been activity for some time.

@wenzeslaus wenzeslaus modified the milestones: 8.0.2, 8.4.0 Feb 27, 2022
@wenzeslaus
Copy link
Member

I fixed the issues, so this can be merged.

@wenzeslaus wenzeslaus merged commit 5ccff03 into OSGeo:main Mar 17, 2023
@wenzeslaus wenzeslaus changed the title i.in.spotvgt.py: fixed E722 do not use bare 'except' warning modules: Replace bare except by Exception in r.unpack and i.in.spotvgt Mar 17, 2023
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Mar 20, 2023
i.in.spotvgt and r.unpack now use Exception instead of bare except. This fixes Flake8 warning E722 (do not use bare 'except').

---------

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
i.in.spotvgt and r.unpack now use Exception instead of bare except. This fixes Flake8 warning E722 (do not use bare 'except').

---------

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants