Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod(x,y) function to r.mapcalc and r3.mapcalc doc #1617

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

agiudiceandrea
Copy link
Contributor

No description provided.

@ninsbl
Copy link
Member

ninsbl commented Jun 17, 2021

Thanks for your contribution, @agiudiceandrea !
Others: should this be backported?

@ninsbl ninsbl added backport_needed manual Documentation related issues labels Jun 17, 2021
@agiudiceandrea
Copy link
Contributor Author

@ninsbl may it be also useful to add the "mod" function also to the wx mcalc_builder module?

@ninsbl
Copy link
Member

ninsbl commented Jun 18, 2021

@ninsbl may it be also useful to add the "mod" function also to the wx mcalc_builder module?

Makes sense to me. Maybe it anyway just was forgotten due to the lack of documentation...

@veroandreo
Copy link
Contributor

Thanks for your contribution, @agiudiceandrea !
Others: should this be backported?

I believe so. It's not a new feature per se... it was already there but not documented, is that right?

@agiudiceandrea
Copy link
Contributor Author

It's not a new feature per se... it was already there but not documented, is that right?

Yes, it is.

@mlennert
Copy link
Contributor

mlennert commented Jul 7, 2021

What is the difference between the mod(x,y) function and x%y ?

@agiudiceandrea
Copy link
Contributor Author

What is the difference between the mod(x,y) function and x%y ?

They ere the same arithmetic operation, like x^y and pow(x,y).

@ninsbl ninsbl added this to the 8.0.0 milestone Aug 10, 2021
@wenzeslaus wenzeslaus modified the milestones: 8.0.0, 8.2.0 Aug 26, 2021
@ninsbl
Copy link
Member

ninsbl commented Oct 14, 2021

Trying to trigger re-run of the stuck flake8 check by closing and reopening the PR as suggested here:
https://stackoverflow.com/questions/52408592/how-to-relaunch-github-check-without-pushing-new-commits/52412240 , so this can be merged

@ninsbl ninsbl closed this Oct 14, 2021
@ninsbl ninsbl reopened this Oct 14, 2021
@ninsbl ninsbl merged commit 0fe9463 into OSGeo:main Oct 14, 2021
ninsbl pushed a commit that referenced this pull request Oct 14, 2021
* Add mod(x,y) function to r.mapcalc doc

* Add mod(x,y) function to r3.mapcalc doc

* Add mod(x,y) to r.mapcalc wx functions list

* Solve conflicts in gui/wxpython/modules/mcalc_builder.py
@ninsbl
Copy link
Member

ninsbl commented Oct 14, 2021

Backported in 0adac7f

@agiudiceandrea agiudiceandrea deleted the patch-1 branch October 15, 2021 03:25
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
* Add mod(x,y) function to r.mapcalc doc

* Add mod(x,y) function to r3.mapcalc doc

* Add mod(x,y) to r.mapcalc wx functions list
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* Add mod(x,y) function to r.mapcalc doc

* Add mod(x,y) function to r3.mapcalc doc

* Add mod(x,y) to r.mapcalc wx functions list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manual Documentation related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants