-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: upgrade to autoconf 2.69 #1845
Conversation
Now I have no more planned changes to this PR. Please go ahead and test! This apparently doesn't cause any regression as I can see, succeeds on all CIs too. I would be good to get this change to 8.0 for future ease of maintenance on that line of releases. But I don't want this to be a blocker, hence I put this on 8.2 milestone. Some notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of autoconf 2.13 tools has caused headaches before, but nobody dared to tackle the task of upgrading to a newer version! Thanks a lot, great work!
There is a bit of custom code in the old configure setup, e.g. regarding LFS, that could be replaced by using predefined tests available with the autoconf 2.69 suite. That would be worth another PR. Inspiration for updating provides e.g. GDAL's configure system.
Awesome, this should also fix #560. I am not sure whether to wait for 8.2 with this. |
I did a simple compile/run test. Everything seems to be fine. I would +1 pushing this to 8.0. |
Thanks, that's nice to hear! :-)
Yes I noticed, and there are probably more things that may be fixed/improved later on when we have this initial upgrade working. @ all Actually, we may also considerate bringing this back to 7.8. See #560. A short time 7.8.6RC3 for testing...? Just throwing the question for consideration. |
I have now updated with fixes from release branch 7.8 (#1869, #1870, #1883). |
Now G78 configures, builds and runs (I did test) for Windows with autoconf 2.69 too, see log:
Merging this to main branch (G8) too. |
Updates the configure system to autoconf 2.69 (of 2012) from the rather outdated version 2.13 (1999).
Apart from general modernisation this also fixes problems (at least for me) with iconv as reported in #513.