Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix configuration error and warnings after autoconf-2.69 update #1869

Merged

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Sep 15, 2021

This addresses configuration failure on Alpine Docker and warnings on all (Alpine, Debian, Ubuntu).

  • Remove single quotes around include directory in configuration causing compilation error
  • Remove non-existing configuration options

(To check available configuration options: ./configure --help.

ALPINE

#22 [build 4/6] RUN echo "  => Configure and compile grass" &&     /src/grass_build/configure       --enable-largefile       --with-cxx       --with-proj --with-proj-share=/usr/share/proj       --with-gdal       --with-pdal       --with-python       --with-geos       --with-sqlite       --with-bzlib       --with-zstd       --with-cairo --with-cairo-ldflags=-lfontconfig       --with-fftw       --with-postgres --with-postgres-includes='/usr/include/postgresql'       --without-freetype       --without-openmp       --without-opengl       --without-nls       --without-mysql       --without-odbc       --without-openmp       --without-ffmpeg        &&     make -j 2 &&     make install &&     ldconfig /etc/ld.so.conf.d
#22 0.066   => Configure and compile grass
#22 0.145 configure: WARNING: unrecognized options: --with-proj, --with-python, --without-ffmpeg


...

#22 6.350 checking for location of PostgreSQL includes... '/usr/include/postgresql'
#22 6.351 configure: error: *** PostgreSQL includes directory '/usr/include/postgresql' does not exist.
------
Dockerfile:167
--------------------
 166 |     # Configure compile and install GRASS GIS
 167 | >>> RUN echo "  => Configure and compile grass" && \
 168 | >>>     /src/grass_build/configure $GRASS_CONFIG && \
 169 | >>>     make -j $NUMTHREADS && \
 170 | >>>     make install && \
 171 | >>>     ldconfig /etc/ld.so.conf.d
 172 |     
--------------------
error: failed to solve: process "/bin/sh -c echo \"  => Configure and compile grass\" &&     /src/grass_build/configure $GRASS_CONFIG &&     make -j $NUMTHREADS &&     make install &&     ldconfig /etc/ld.so.conf.d" did not complete successfully: exit code: 1
##[error]buildx failed with: error: failed to solve: process "/bin/sh -c echo \"  => Configure and compile grass\" &&     /src/grass_build/configure $GRASS_CONFIG &&     make -j $NUMTHREADS &&     make install &&     ldconfig /etc/ld.so.conf.d" did not complete successfully: exit code: 1

UBUNTU + DEBIAN

#23 [18/33] RUN /src/grass_build/configure   --with-cxx   --enable-largefile   --with-proj --with-proj-share=/usr/share/proj   --with-gdal=/usr/bin/gdal-config   --with-geos   --with-sqlite   --with-cairo --with-cairo-ldflags=-lfontconfig   --with-freetype --with-freetype-includes="/usr/include/freetype2/"   --with-fftw   --with-postgres=yes --with-postgres-includes="/usr/include/postgresql"   --with-netcdf   --with-zstd   --with-bzlib   --with-pdal   --without-mysql   --without-odbc   --without-openmp   --without-ffmpeg   --without-opengl     && make -j 4     && make install && ldconfig
#23 0.238 configure: WARNING: unrecognized options: --with-proj, --without-ffmpeg

- Remove single quotes around include directory in configuration
- Remove non-existing configuration options
@nilason
Copy link
Contributor Author

nilason commented Sep 15, 2021

@mmacata Could this solve CI Docker failure on release branch 7.8 after autoconf update?

@mmacata
Copy link
Contributor

mmacata commented Sep 16, 2021

Yes - I tested the build of the alpine image locally by removing the single quotes around postgres-includes directory and the configure step is successful again. Removing the other options also makes sense as they are not available anymore. I just saw that they are still described in the wiki, but that is another task.
Thank you for looking into this!

@nilason
Copy link
Contributor Author

nilason commented Sep 16, 2021

@mmacata Thanks for testing!

@nilason nilason merged commit 7940e83 into OSGeo:releasebranch_7_8 Sep 16, 2021
@nilason nilason deleted the fix-docker-with-autoconf-2.69 branch September 16, 2021 19:06
@neteler neteler added this to the 7.8.6 milestone Dec 9, 2021
@neteler neteler added the docker Docker related label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants