r3.out.netcdf: Use current major version in history attribute

[wenzeslaus]

r3.out.netcdf creates a netCDF file with attribute history which contains software. This removes the hard-coded software version information and uses the current major version instead for the history text. It uses fairly general macros to encapsulate stringification to avoid complex code needed to use snprintf.

The documentation contains the output, so the version should be there, but I removed it from the examples to avoid the need for updates (making the documentation little less precise).

[wenzeslaus]

This is ready for review and would be good to get merged before v8.3 because it removes some outdated references to v7 in the code.

The question is, is removing the GRASS GIS version number from the metadata desired?

[neteler]

The question is, is removing the GRASS GIS version number from the metadata desired?

As it is actually HISTORY_TEXT being set, I'd suggest to replace the hardcoded version with the respective VERSION variable containing the GRASS GIS version used to write out the file.

[wenzeslaus]

It now uses GRASS_VERSION_MAJOR. The string manipulation code is somewhat complicated (necessary?).

I did not update the documentation, so the PR is removing the version number from there right now. I'm not sure how to make it simple to maintain while keeping it absolutely precise.

I could also use GRASS_VERSION_STRING which is already a string, but it contains year ("@GRASS_VERSION_NUMBER@ (@GRASS_VERSION_DATE@)"). Alternatively, we could also define GRASS_VERSION_NUMBER in C in version.h. In any case, this would make the documentation harder to update if we opt for including the version number there.

[nilason]

You will need to clang-format this.

[wenzeslaus]

Thanks for feedback @neteler and @nilason. I'm ready to merge this.

[nilason]

Looks good to me!