-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: Always use current major version in VTK outputs (r.out.vtk, r3.out.vtk, v.out.vtk) #2343
Conversation
9e1096f
to
461beca
Compare
This removes outdated references to v7 from the generated VTK files. With this PR, no further updates will be needed because the version is simply not there. This is similar to #2342. The any mention of the version is removed completely, so the question is if it is okay. |
Now the current major version is obtained. Given that the header line should describe the data, title might be actually more appropriate. Full version number could be used too, but similarly to #2342, it would be a change in output, so perhaps a topic for a separate PR. The existing test is now enabled and the values updated. The test will need an update for the next major version. |
71f613f
to
5348f37
Compare
…, v.out.vtk) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line. This removes the major version from the string.
5348f37
to
f8db520
Compare
…r3.out.vtk, v.out.vtk) (OSGeo#2343) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
…r3.out.vtk, v.out.vtk) (OSGeo#2343) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
Reference data need update too and will need updates in the future. However, the test will fail and show the need to update, so it should be clear.