grass.pygrass: Fix parameter range error reporting #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
force-pushed
the
fix-pygrass-parameter-checks
branch
from
d7c4e52
to
0fb693a
Compare
|
This passes existing tests and adds new tests, merging. |
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
This fixes parameter range error, uses f-strings, and adds tests for positive min and max and message text.
petrasovaa
pushed a commit
that referenced
this pull request
Feb 14, 2024
This fixes parameter range error, uses f-strings, and adds tests for positive min and max and message text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a parameter value which was out of range from key_desc specified as
0-, grass.pygrass failed to construct the error message and resulting error message for the exception was:This handles the cases with only min or max specified separately, fixes the error message and uses f-strings. The new message is: