r.horizon: adjust bufferzone to multiples of resolution #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
echoix
reviewed
Jan 31, 2024
echoix
reviewed
Feb 7, 2024
echoix
approved these changes
Feb 14, 2024
echoix
approved these changes
Feb 14, 2024
|
@petrasovaa I let you resolve the last comment, and it will merge automatically ;) Then it will be time to resolve the conflicts for the other r.horizon PRs |
petrasovaa
added a commit
that referenced
this pull request
Feb 14, 2024
* r.horizon: adjust bufferzone to multiples of resolution * fix test * restrict input bufferzone to positive values * add tests for negative bufferzone
|
Backport breaks tests, because of a bug in pygrass, either I'll remove the test from 8.3 or #2817 needs to be backported. @wenzeslaus can we backport it? |
|
I recommend removing the test. It is the least invasive change for the upcoming micro release of v8.3 which is close. While the improvement in the message is significant, the fix is may cause trouble if someone wrote their code around it without reading the doc. Next minor, i.e., 8.4, which is relatively close, is a better place for it. |
jadenabrams100
pushed a commit
to ncsu-csc472-spring2024/grass-CI-playground
that referenced
this pull request
Feb 21, 2024
* r.horizon: adjust bufferzone to multiples of resolution * fix test * restrict input bufferzone to positive values * add tests for negative bufferzone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3266. Now it adjust the bufferzone, e.g. for 10m resolution raster, bufferzone 109 gets adjusted to 100.
Just to see the what effect this had, this is a difference between a horizon raster where bufferzone is 100 (even multiples of resolution 10) and 103. Now there is no difference (see the test).
