-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.extension: Remove six dependency #2828
Conversation
wenzeslaus
commented
Feb 14, 2023
•
edited
Loading
edited
- Removes imports from six, uses standard Python 3 imports.
- Removes Python <=2.4 ElementTree import.
- Removes future print_function imports.
- Removes six from g.extension and g.extension.all. Leaves the rest as is.
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports.
While python3-six package is in Travis CI, the build may fail as if there is no six package. Something like this happened before (possibly in Travis) and right now it happens for all runs. This removes six from g.extension and g.extension.all, but not from anything else. This should allow the build to run without six. |
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.
Any objections to backport this PR to G8.2? |
six is for Python 2, but we require Python 3 for v8 and tests are running for some time now, so no objections from me. |
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.