g.extension: Remove six dependency #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenzeslaus
commented
Feb 14, 2023
•
wenzeslaus
commented
- Removes imports from six, uses standard Python 3 imports.
- Removes Python <=2.4 ElementTree import.
- Removes future print_function imports.
- Removes six from g.extension and g.extension.all. Leaves the rest as is.
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports.
|
While python3-six package is in Travis CI, the build may fail as if there is no six package. Something like this happened before (possibly in Travis) and right now it happens for all runs. This removes six from g.extension and g.extension.all, but not from anything else. This should allow the build to run without six. |
petrasovaa
approved these changes
Feb 14, 2023
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.
|
Any objections to backport this PR to G8.2? |
|
six is for Python 2, but we require Python 3 for v8 and tests are running for some time now, so no objections from me. |
neteler
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* Removes imports from six, uses standard Python 3 imports. * Removes Python <=2.4 ElementTree import. * Removes future print_function imports. Removes six only from g.extension and g.extension.all. Leaves the rest as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.