Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis: ModuleNotFoundError: No module named 'six' (G 8.2) #2845

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix Travis: ModuleNotFoundError: No module named 'six' (G 8.2) #2845

merged 1 commit into from
Feb 21, 2023

Conversation

neteler
Copy link
Member

@neteler neteler commented Feb 21, 2023

At time Travis CI fails in releasebranch_8_2 with:

Traceback (most recent call last):

  File "/home/travis/build/OSGeo/grass/dist.x86_64-pc-linux-gnu/utils/mkhtml.py", line 37, in <module>
    from six.moves.urllib import request as urlrequest

ModuleNotFoundError: No module named 'six'

(Example for a failed Travis run: https://github.com/OSGeo/grass/pull/2843/checks?check_run_id=11475577650)

This PR addresses the removal of six in a simple way.

Side note: Travis does not fail in main due to PR #2547, see
17fc1d8#diff-3e1684c5c5d40b273b6488a9b5a5558f556d2bcf2973ba5106b6125e01aa6959

@neteler
Fix Travis: ModuleNotFoundError: No module named 'six' (releasebranch…
a223937 
…_8_2)

Currently Travis CI fails in `releasebranch_8_2`:

```
Traceback (most recent call last):

  File "/home/travis/build/OSGeo/grass/dist.x86_64-pc-linux-gnu/utils/mkhtml.py", line 37, in <module>
    from six.moves.urllib import request as urlrequest

ModuleNotFoundError: No module named 'six'
```

(Example for a failed Travis run: https://github.com/OSGeo/grass/pull/2843/checks?check_run_id=11475577650)

This PR addresses the removal of `six` in a simple way.

Side note: Travis does not fail in `main` due to PR OSGeo#2547,
OSGeo@17fc1d8#diff-3e1684c5c5d40b273b6488a9b5a5558f556d2bcf2973ba5106b6125e01aa6959
@neteler neteler added bug Something isn't working CI Continuous integration labels Feb 21, 2023
@neteler neteler added this to the 8.2.2 milestone Feb 21, 2023
@neteler neteler self-assigned this Feb 21, 2023
@wenzeslaus
Copy link
Member

You may need to get #2828, too. six in g.extension was a problem on main last week, although we have python3-six in our Travis dependencies.

@neteler
Copy link
Member Author

neteler commented Feb 21, 2023 •
edited
Loading

Still:

Traceback (most recent call last):
  File "/home/travis/build/OSGeo/grass/dist.x86_64-pc-linux-gnu/scripts/g.extension", line 175, in <module>

    from six.moves.urllib import request as urlrequest

ModuleNotFoundError: No module named 'six'

Ok, in addition we need the backport of "g.extension: Remove six dependency": #2828

EDIT: saw your comment only after submitting mine, wenzeslaus

@neteler
Copy link
Member Author

neteler commented Feb 21, 2023

You may need to get #2828, too

Backport done in 453d019

@neteler
Copy link
Member Author

neteler commented Feb 21, 2023

Yay, Travis CI - Pull Request Successful in 8m — Build Passed

@neteler neteler merged commit 505ac5b into OSGeo:releasebranch_8_2 Feb 21, 2023
@neteler neteler deleted the travis_fix_six_missing branch February 21, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@neteler neteler

Labels
bug Something isn't working CI Continuous integration
Projects
None yet
Milestone
8.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@neteler @wenzeslaus