packaging: Use subprocess instead of os.popen for change log creation #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Mar 1, 2024
echoix
reviewed
Mar 1, 2024
…put goes to fout var.
neteler
reviewed
Mar 11, 2024
fixed import mistake Co-authored-by: Markus Neteler <markus@neteler.org>
kpolchow
reviewed
Mar 16, 2024
echoix
previously requested changes
Mar 17, 2024
|
@kpolchow almost there! This PR is almost ready! |
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
|
CI is still failing. I think it is formatting with black that was forgotten. |
thanks for the notice, I fixed the formatting reports from flake8 and black |
wenzeslaus
requested changes
Mar 19, 2024
…ted to optionally add rev_range
fixed empty ChangeLog in PR
wenzeslaus
approved these changes
Mar 21, 2024
wenzeslaus
changed the title
neteler
pushed a commit
that referenced
this pull request
Sep 29, 2024
…#3469) This addresses a warning from Bandit about an injection attack risk by using subprocess.Popen instead of os.popen. --------- Co-authored-by: kpolchow <polchow.kira@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a warning from Bandit about an injection attack risk by using subprocess.Popen instead of os.popen.