Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: Use subprocess instead of os.popen for change log creation #3469

Merged
merged 27 commits into from
Mar 21, 2024
Merged

packaging: Use subprocess instead of os.popen for change log creation #3469

merged 27 commits into from
Mar 21, 2024

Commits on Feb 26, 2024

  1. Addresses warning from Bandit - Injection attack risk in util file fo… 

    …r gitlog
    @kpolchow
    kpolchow committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    66806c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. fixed issues w/ changed variable names, consistent w/ before. all out… 

    …put goes to fout var.
    @kpolchow
    kpolchow committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a1dc3b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Update utils/gitlog2changelog.py 

    fixed import mistake

Co-authored-by: Markus Neteler <markus@neteler.org>
    @kpolchow @neteler
    kpolchow and neteler authored Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e3776ec View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. added a new line to comply with linux convention 

    Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
    @naidneelttil @echoix
    naidneelttil and echoix authored Mar 17, 2024
    Configuration menu
    Copy the full SHA
    d440e08 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. formatted the code with black, a python formatter

    @naidneelttil
    naidneelttil committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e006aaa View commit details
    Browse the repository at this point in the history

  2. remove import os as it is no longer used

    @naidneelttil
    naidneelttil committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6c501bc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. tried to optionally add rev_range, on an experiemental branch

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3e5f906 View commit details
    Browse the repository at this point in the history

  2. tried to optionally append by adding it to the list

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1dea42b View commit details
    Browse the repository at this point in the history

  3. changed the command from subprocess popen to suprocess run and attemp… 

    …ted to optionally add rev_range
    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    374ed2a View commit details
    Browse the repository at this point in the history

  4. formatted the document according the black (the python formatter)

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3efe1f6 View commit details
    Browse the repository at this point in the history

  5. added the full path for git

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b6f213a View commit details
    Browse the repository at this point in the history

  6. added missing forward slash

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d5dbd95 View commit details
    Browse the repository at this point in the history

  7. attempt to optionally add rev_range

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d67e07d View commit details
    Browse the repository at this point in the history

  8. format with black (python formatter)

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    21b3fcb View commit details
    Browse the repository at this point in the history

  9. appended rev_range as a formatted string

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    395d1c4 View commit details
    Browse the repository at this point in the history

  10. test commit, if the args are swallowed if empty, how does that create… 

    … artifacts?
    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a02626c View commit details
    Browse the repository at this point in the history

  11. changing back to popen for testing

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    38cbe73 View commit details
    Browse the repository at this point in the history

  12. changed popen spelling

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b6018a3 View commit details
    Browse the repository at this point in the history

  13. attempt to optionally add argument to git command by reversing order … 

    …of check
    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    50c8397 View commit details
    Browse the repository at this point in the history

  14. removed the format string, and just appended rev_range if applicable

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2c29f68 View commit details
    Browse the repository at this point in the history

  15. revert back to a semi working version (util-injection)

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f7aea51 View commit details
    Browse the repository at this point in the history

  16. optionally added rev_range if arguments are given

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9d8cadc View commit details
    Browse the repository at this point in the history

  17. try with shell = true

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    68680ad View commit details
    Browse the repository at this point in the history

  18. try encoding with utf8 to avoid getting back bytes

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7278bff View commit details
    Browse the repository at this point in the history

  19. add the empty new line at the end to keep with linux convention

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d129ff2 View commit details
    Browse the repository at this point in the history

  20. Merge pull request #24 from ncsu-csc472-spring2024/releasebranch_popen 

    fixed empty ChangeLog in PR
    @naidneelttil
    naidneelttil authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8307e7e View commit details
    Browse the repository at this point in the history

  21. fixed formatting warning by black python formatter

    @naidneelttil
    naidneelttil committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f22bf29 View commit details
    Browse the repository at this point in the history