CI(ruff): Fine tune posting Ruff suggestions

[echoix]

I overlooked the situation where some ruff errors can and cannot be fixed in the same pass. The exit code won’t be 0 if not all files were fixed. This prevented to reach the step where the diff was stored as an artifact to upload suggestions, to post.

So instead of setting the ruff step with continue-on-errors: true, which would have shown the step as gray (passing), even when rules without fixes are failing, I set the condition to if: ${{ !cancelled() }} as mentioned in the docs for always() https://docs.github.com/en/actions/learn-github-actions/expressions#always

I also spotted a copy-paste typo in the post-pr-reviews workflow, that I had already fixed on another branch but forgot to apply on the one that ended up being a PR.

Finally, I reconsidered my initial position on only applying the safe fixes. Since it is not directly committing, only posting suggestions, it makes sense to show suggestions on what will still remain an error, but without the suggested fixes. Unlike Black, we might need to think a bit about the fixes anyways, when available. Following that thought, I don’t think it’s appropriate in pre-commit to make unsafe fixes on behalf of the user, without any review.

[echoix]

I might at a later point in time work to have full error descriptions in the suggestion too, but it will require a bit more thought to make it work as safely as the current diff-based approach that works fine even from forks

[ninsbl]

While I cannot judge how this is implemented as I don't know the involved tools to well, your reasoning sounds convincing...