Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(ruff): Fine tune posting Ruff suggestions #3978

Merged
merged 4 commits into from
Jul 4, 2024
Merged

CI(ruff): Fine tune posting Ruff suggestions #3978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4efd03d
CI(ruff): Fix typo in ruff suggestions
echoix Jul 3, 2024
e288ca3
CI(ruff): Upload suggestions even if not all linting errors were fixed
echoix Jul 3, 2024
1a23c79
CI(ruff): Try suggesting more changes
echoix Jul 3, 2024
2b30876
CI(ruff): Upload suggestions even if not all linting errors were fixed
echoix Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/post-pr-reviews.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
CI_REPO_NAME: ${{ github.event.workflow_run.repository.name }}
# CI_PULL_REQUEST: "" # Populated from reviewdog's "-guess" flag since hard to get
- name: Post Ruff suggestions
if: ${{ steps.tools.outputs.black == 'true' }}
if: ${{ steps.tools.outputs.ruff == 'true' }}
run: |
TMPFILE="diff-${INPUT_TOOL_NAME}.patch"
GITHUB_ACTIONS="" reviewdog \
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/python-code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,12 @@
- name: Install Ruff
run: pip install ruff==${{ env.RUFF_VERSION }}
- name: Run Ruff
run: ruff check --output-format=github . --preview --fix
run: ruff check --output-format=github . --preview --fix --unsafe-fixes
- name: Create and uploads code suggestions to apply for Ruff
# Will fail fast here if there are changes required
id: diff-ruff
# To run after ruff step exits with failure when rules don't have fixes available
if: ${{ !cancelled() }}
uses: ./.github/actions/create-upload-suggestions
with:
tool-name: ruff
Expand Down Expand Up @@ -144,7 +146,7 @@

- uses: rui314/setup-mold@65685f45207903d37d006cd402c397653c57660e # v1
- name: Build
run: .github/workflows/build_${{ matrix.os }}.sh $HOME/install

Check warning on line 149 in .github/workflows/python-code-quality.yml

View workflow job for this annotation

GitHub Actions / Python Code Quality Checks (ubuntu-22.04) 

  Temporarily downgraded pytest-pylint and pytest to allow merging other PRs.  The errors reported with a newer version seem legitimite and should be fixed   (2023-10-18, see https://github.com/OSGeo/grass/pull/3205)  (2024-01-28, see https://github.com/OSGeo/grass/issues/3380)

- name: Add the bin directory to PATH
run: |
Expand Down