r.clump: Fix unchecked return value from lseek #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
wenzeslaus
requested changes
Aug 7, 2024
wenzeslaus
changed the title
added 2 commits
August 7, 2024 17:22
echoix
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I think the requested changes by @wenzeslaus and @nilason were addressed correctly. I think the PR is in good shape too, do any of you two can take a last look?
Not quite yet. See #4151 (comment). |
nilason
approved these changes
Sep 9, 2024
wenzeslaus
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue identified by coverity scan (CID : 1415709) [unchecked return value from library]
The checks are added for lseek.