Refactoring & dependency updates #17

Path setup for ISIS was lost in GIS variable setup. This moves it to the library, where other paths and integrations are initialized. The variables are left as is, without further testing.

This patch continues the work from 917ba58. It's a good practice to immediately reset the file pointer once we do fclose on it, as it prevents using/closing descriptor allocated to another file in the future execution paths. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>

…_text (#4293)

… in scripts directory part 1 (#4238)

Currently, if 'HAVE_OGR' macro is defined, as part of execution, we order all formats by name using qsort. But, list containing all formats is assigned based on a conditional and if the conditional fails, it can be NULL. Behavior of qsort is undefined when a NULL ptr is passed as array argument. To avoid getting into that situation, check if the array is NULL before performing qsort on it. This issue was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>

* g.gui.gmodeler: start refactoring * assign results from _getLabel() directly instead of using intermediate vars * do not run Getlabel() if not needed * VariableListCtrl: simplify (no need to run one loop twice)

#4298)

* CI(deps): Update ruff to v0.6.4 * style: Fix List index lookup in `enumerate()` loop (PLR1736) in __writeNvizState * style: Fix Unnecessary lookup of dictionary value by key (PLR1733) in iscatt_core.py * style: Fix `enumerate` index is unused, use `for plane in constants` instead (FURB148) in __writeNvizState --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>

Currently, filling list with GDAL driver names is based on a conditional and if the conditional fails, the list can be NULL. We pass this list to qsort to sort the names, but behavior of qsort with a NULL array is undefined. To avoid getting into this situation, check if the array is NULL before performing qsort on it. This issue was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>

* create unit tests for r.proj * change the source project * update the validation values according to the map in the project * remove shell cmd, update doc, modify precision

) * v.vol.rst: Initialize structure contents before passing it around `skip_point` structure is not initialized when declared. This was found using cppcheck tool. Only when `cv` is true, `skip_point` contents are filled and the structure is used. cppcheck raised the issue when 'cv' is false. Technically, we don't need skip_point in such cases and not initializing it won't affect the execution. Nevertheless, it's a good practice to initialize structure contents at the time of declaration. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> * Use correct literal for double type Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com> --------- Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

…4281) * v.generalize: Initialize all of structure contents before using it Currently, in `head` which is a `POINT_LIST` structure, we are only initializing the next pointer to NULL, but data present in the point substructure is not initialized which implies that it would be filled with random data. To avoid such scenario, initialize point coordinates to zero. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> * Use correct literal for double type Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com> --------- Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

* resolved flake8 in utils * updated .flake8 --------- Co-authored-by: Arohan Ajit <aajit@chirpn.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ass.py (#4289) * fixed flake8 errors in lib/init/grass.py * fixed flake8 details .flake8

* drivers: copy into fixed size buffer issue * Requested changes * without variable * Update db/drivers/sqlite/db.c Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com> * Use Db statements --------- Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

)

* fixing TypeError ColumnSorterMixin #4277 * #4277 fix ColumnSorterMixin error

… in the temporal directory (#4229)

* resolved some more flake8 warnings * fixed all man flake8 errors except buildhtml * Update .flake8 --------- Co-authored-by: Arohan Ajit <aajit@chirpn.com>

* revert 2cf98da * fix regression introduced in f99780c

Add wrapper function for strlcat(), using system function if available, otherwise uses implementation by Todd C. Miller originated from https://github.com/openbsd/src/blob/e291b8af02e5c2b53d7ddb1f0c9c0fd608b97d45/lib/libc/string/strlcat.c. G_strlcat() is a safer alternative to strcat().

* Fix Resource Leak issue * Fix Resource Leak issue

* fix Resource Leak issue * Update display/d.vect/attr.c

…ds (#4501) In some situations, when some conditionals fails, we would be assigning uninitialized variables to values, which is undefined behavior. Fix that by assigning a value to the variables. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>

… overflow (#4512) Fixes two new issues reported by Coverity Scan: - Handles case of unsuccessful creation of json string - Silences false positive issue for string copy operation to buffer of size GMAPSET_MAX from G_mapset().

Ruff rule PT004 is deprecated, so doesn't run with --preview flag, but still appears without the --preview flag. Since the only error won't be fixed, ignore that rule for the time being.

* pytest: Collect code coverage in multiple workers too * utils: Handle paths that already have a .py extension in coverage_mapper * CI: Set INITIAL_GISBASE and INITIAL_PWD env vars for running pytest with multiple workers * Coverage: Omit gui/wxpython subfolders for now They are not covered at all and take some noticeable time to collect * Coverage: Remove unneeded omit patten for gui/wxpython subfolders

* Fix Resource Leak issue * requested changes

Resource Leak

Makes the script runnable on e.g. BSD platforms, which does not ship with md5sum. In addition fixes shellcheck warnings.

* Vlib: always write out topo files in update mode * delete support files only when closing * fix pygrass Vect_close --------- Co-authored-by: Huidae Cho <grass4u@gmail.com>

Similarly to #4401, this replaces usage of MASK by mask on additional places. It also improves wording of a warning in i.fft.

… on Cray (#4363) When the code is being compiled for CRAY HPC machines, a macro and a function to convert IEEE single precision floating point number to CRAY number are defined. To adjust the base, '16258' constant is being used, which according to C rules (C99, section 6.4.4.1, subsection semantics) fits into an integer. Right shifting that integer, which is of 32 bits, by 48 results in integer overflow. Avoid this by defining the literal constant with the long data type. This comes with an extended discussion in PR #4363 and an idea to remove the code completely. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>

* CI: Create a workflow to assign milestones * Add GH_TOKEN for gh cli * CI: Add GH_REPO for gh cli * CI: View PR from gh cli using html_url * CI: Download and parse version file * CI: Show version file * CI: Download and parse version file using a pipe * Show version file output Clean up * Pipe version file env to head * Rename variables to milestone and title * Edit PR with milestone * Get milestone from gh cli * Add comment on why API call is used for getting milestone * Show if the PR has a milestone set or not * Do not run steps if a milestone is already set * Add pull_request_target closed trigger * Add ref as url parameter * Remove debugging steps * CI: Handle RC followed by numbers in sed pattern replacement

* Remove Makefiles. * Move the functioning test to the testsuite directory for the gunittest to pick it up. * Remove the extended example how to run gunittest. Point to the CI in the README instead. * Remove hemisphere generator because it does not test anything by itself (without further processing and a human). * Remove GPS import tests as the tools are not in core. * Remove division into subdirectories. The directories with the code should be used instead. * Improve the test for gunittest loader function with some duplication but now creating an overview of .py and .sh tests.

Again, use lowercase mask and other wording instead of MASK when talking about masking, similar to #4401 and #4495. It also adjusts the wording in r.topidx and i.segment.

ymdatta and others added 30 commits September 6, 2024 21:35

ps.map: Initialize variable before using it in conditional (#4286)

9bbfd6b

checks: Flake8 F841 fixes in the scripts directory part 2 (#4241)

102bc38

* Fix F841 problems in `scripts` directory * Update `.flake8` with fixes for F841 * Remove unused lines based on reviewed suggestions

CI(deps): Update alpine:3.20 Docker digest to beefdbd (#4287)

39e1e11

grass.app: Move ISIS integration to the library (#4169)

83ee146

Path setup for ISIS was lost in GIS variable setup. This moves it to the library, where other paths and integrations are initialized. The variables are left as is, without further testing.

grass.temporal.stds_export: Use pathlib Path.read_text and Path.write…

d7f4977

…_text (#4293)

checks: flake8 F841 (local variable assigned to but never used) fixes…

57cb4d9

… in scripts directory part 1 (#4238)

wxGUI/gmodeler: dialogs code refactoring (#3816)

b1c8d10

* g.gui.gmodeler: start refactoring * assign results from _getLabel() directly instead of using intermediate vars * do not run Getlabel() if not needed * VariableListCtrl: simplify (no need to run one loop twice)

r.univar: fix MASK check with nprocs > 1 (#4297)

cc2797c

CI(deps): Update DeterminateSystems/nix-installer-action action to v14 (

258752c

#4298)

r.proj: Create unit tests (#4225)

997624b

* create unit tests for r.proj * change the source project * update the validation values according to the map in the project * remove shell cmd, update doc, modify precision

t.rast.accumulate: remove printing (#4301)

adcdf28

CI: Resolve flake8 issues in utils directory (#4303)

e4fdf90

* resolved flake8 in utils * updated .flake8 --------- Co-authored-by: Arohan Ajit <aajit@chirpn.com>

CI(deps): Update docker/dockerfile Docker tag to v1.10 (#4305)

569c730

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

CI: Update .flake8 configuration and fix flake8 errors in lib/init/gr…

5719ba6

…ass.py (#4289) * fixed flake8 errors in lib/init/grass.py * fixed flake8 details .flake8

CI(deps): Update peter-evans/create-pull-request action to v7.0.2 (#4311

4d5184d

)

GUI: fix ColumnSorterMixin regression (#4310)

5de8682

* fixing TypeError ColumnSorterMixin #4277 * #4277 fix ColumnSorterMixin error

Checks: flake8 F841 (local variable assigned to but never used) fixes…

8c23c2e

… in the temporal directory (#4229)

CI: Fix Flake8 linter errors in man/ directory (#4292)

b7bcd06

* resolved some more flake8 warnings * fixed all man flake8 errors except buildhtml * Update .flake8 --------- Co-authored-by: Arohan Ajit <aajit@chirpn.com>

contributing: update style guide for C (#4312)

9aeabc1

ps.map: Fix copy into fixed size buffer issue in do_scalebar.c (#4307)

d77f457

GUI: gmodeler fix adding tool (#4309)

2c1df9f

* revert 2cf98da * fix regression introduced in f99780c

CI(deps): Update github/codeql-action action to v3.26.7 (#4314)

7dbb49b

ShubhamDesai and others added 29 commits October 12, 2024 10:03

i.ortho.photo: Fix Resource Leak in find_init.c (#4388)

0feea31

lib/vector/Vlib: Fix copy into buffer size issue in color_read.c (#4462)

9df8433

checks: Remove extra semicolons in r.terraflow (#4494)

4cf93d2

CI(deps): Update actions/upload-artifact action to v4.4.3 (#4481)

71066f4

v.colors: Fix Resource Leak issue in read_rgb.c (#4497)

542f3b4

v.to.db: Fix Resource Leak issue in areas.c (#4498)

779af80

* Fix Resource Leak issue * Fix Resource Leak issue

d.vect: Fix Resource Leak issue in attr.c (#4496)

03675b0

* fix Resource Leak issue * Update display/d.vect/attr.c

CI(deps): Lock file maintenance (#4509)

3c4aa6d

CI(deps): Lock file maintenance (#4510)

cb7cbab

r.carve: Fix resource leak issue in enforce_ds.c (#4505)

b5289ee

gui: Solve a recursion error in gui/wxpython/lmgr/giface.py (#4514)

e139a4c

style: Ignore deprecated PT004 rule (#4520)

761d98a

Ruff rule PT004 is deprecated, so doesn't run with --preview flag, but still appears without the --preview flag. Since the only error won't be fixed, ignore that rule for the time being.

v.net.timetable: Fix Resource Leak issue in main.c (#4508)

a98691f

* Fix Resource Leak issue * requested changes

v.kernel: Fix resource Leak issue in main.c (#4506)

f241532

Resource Leak

lib/vector/Vlib: Fix Resource leak issue in geos.c (#4507)

c5c5ec5

CI(deps): Update github/codeql-action action to v3.26.13 (#4518)

15c5737

tests: enable use of md5 bin for checksum in raster_md5test.sh (#4527)

ca171b7

Makes the script runnable on e.g. BSD platforms, which does not ship with md5sum. In addition fixes shellcheck warnings.

lib/vector/Vlib: always write out topo files in update mode (#3459)

f7d2ecf

* Vlib: always write out topo files in update mode * delete support files only when closing * fix pygrass Vect_close --------- Co-authored-by: Huidae Cho <grass4u@gmail.com>

r.sim.water: fix logfile writing (#4522)

c0c5380

doc: Use lowercase for 2D raster mask and other masks (#4495)

f22c9a2

Similarly to #4401, this replaces usage of MASK by mask on additional places. It also improves wording of a warning in i.fft.

doc: Use lowercase for mask (#4529)

bc9cb2a

Again, use lowercase mask and other wording instead of MASK when talking about masking, similar to #4401 and #4495. It also adjusts the wording in r.topidx and i.segment.

r.in.gridatb: check if opening of file succeeds (#4532)

2415894

grass.script: Fixed E722 in v.what.shrds/ (#4530)

362bee3

a0x8o merged commit 362bee3 into a0x8o:main Oct 16, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring & dependency updates #17

Refactoring & dependency updates #17

a0x8o commented Oct 8, 2024

Refactoring & dependency updates #17

Refactoring & dependency updates #17

Conversation

a0x8o commented Oct 8, 2024