grass.app: Move ISIS integration to the library #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path setup for ISIS was lost in GIS variable setup. This moves it to the library where other paths and integrations are initialized. This is untested. I'm leaving the variables as is.
|
@YannChemin I think you are the original author here. Do you want to take this opportunity to review the current state? |
|
@afrigeri please take a look as well. |
|
As far as the proposed code change, anyone please review and let's get this merged. I can get back to this when there are any followup changes proposed by @afrigeri or @YannChemin. |
echoix
approved these changes
Sep 3, 2024
echoix
approved these changes
Sep 3, 2024
|
Wow! Thanks @wenzeslaus and all |
|
With no other responses for the week, and the fact that I see @afrigeri 's thumbs up on last month's comment and his reponse, I'm moving this forward |
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Path setup for ISIS was lost in GIS variable setup. This moves it to the library, where other paths and integrations are initialized. The variables are left as is, without further testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path setup for ISIS was lost in GIS variable setup. This moves it to the library where other paths and integrations are initialized.
This is untested. I'm leaving the variables as is.