Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.jupyter: Ensure width and height in InteractiveMap are integers #4221

Merged
merged 5 commits into from
Aug 28, 2024
Merged

grass.jupyter: Ensure width and height in InteractiveMap are integers #4221

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
369f5f6
Casted user input to float
Aug 23, 2024
4dd6e1d
Merge branch 'main' into grass.jupyter-interactive
cwhite911 Aug 26, 2024
b2a7a13
Moved type casting into constructor
Aug 26, 2024
4cfc698
Merge branch 'main' into grass.jupyter-interactive
cwhite911 Aug 27, 2024
7f9a902
Moved width parameter
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/grass/jupyter/interactivemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@ def _import_ipyleaflet(error):
import xyzservices # pylint: disable=import-outside-toplevel

# Store height and width
self.width = width
self.height = height
self.width = int(width)
self.height = int(height)
self._controllers = {}

# Store vector and raster name
Expand Down Expand Up @@ -745,7 +745,7 @@ class InteractiveQueryController:
_ipywidgets: The ipywidgets module.
raster_name: The name of the raster layer.
vector_name: The name of the vector layer.
width: The width of the map.
width: The width of the map as an int.
query_control: The query control.

"""
Expand All @@ -764,8 +764,8 @@ def __init__(
self._ipywidgets = ipywidgets
self.raster_name = rasters
self.vector_name = vectors
self.width = width
self.query_control = None
self.width = width
petrasovaa marked this conversation as resolved.
Show resolved Hide resolved

def activate(self):
"""Activates the interactive querying."""
Expand Down
Loading