-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.jupyter: Ensure width and height in InteractiveMap are integers #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be solved in InteractiveMap constructor. Simplest would be to do:
self.width = int(width)
self.height = int(height)
and let it throw the exception.
That makes sense. |
petrasovaa
reviewed
Aug 27, 2024
petrasovaa
approved these changes
Aug 28, 2024
petrasovaa
changed the title
grass.jupyter: InteractiveQueryController width check bug
grass.jupyter: Ensure width and height in InteractiveMap are integers
Aug 28, 2024
ShubhamDesai
pushed a commit
to ShubhamDesai/grass
that referenced
this pull request
Aug 29, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Sep 5, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users input wasn't getting checked here causing the query to fail if the user defined the
width
parameter as a string.The code below would render the map and fail when the query_vector tried to return.