Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management #16

Merged
merged 29 commits into from
Sep 5, 2024
Merged

Dependency management #16

merged 29 commits into from
Sep 5, 2024

Conversation

a0x8o
Copy link
Owner

@a0x8o a0x8o commented Sep 4, 2024

contributing: add PR template (https://github.com/OSGeo/grass/pull/4207[)](https://github.com/a0x8o/grass/commit/22b07acb524d29fe980f16f8105f613adea83926)

CI(deps): Lock file maintenance (https://github.com/OSGeo/grass/pull/4227[)](https://github.com/a0x8o/grass/commit/18bbf4b9ef438d38a623ceef174b5cfe9756a1d0)

init: Use pathlib Path.read_text for readfile in main executable (OSGeo#4234

grass.temporal.core: Replace open file + read with pathlib.Path's rea…

wxGUI: fix adding and removing from history for new mapset (https://github.com/OSGeo/grass/pull/4228[)](https://github.com/a0x8o/grass/commit/acfbdd891145c90de10050cfc8222be04070ac91)

wxGUI: Update link to the Natural Earth sample dataset (https://github.com/OSGeo/grass/pull/4223[)](https://github.com/a0x8o/grass/commit/6c5190e20016da5862b133dc0bbba64ab69a91f2)

docs: add guidelines for writing a meaningful pull request (https://github.com/OSGeo/grass/pull/4197[)](https://github.com/a0x8o/grass/commit/42684b32c466cbace161ba70fd15faed9146437e)

CI(deps): Update super-linter/super-linter action to v7.1.0 (https://github.com/OSGeo/grass/pull/4240[)](https://github.com/a0x8o/grass/commit/1cdf3978b110969ae0bbc7546fa142c0a6c7640b)

grass.jupyter: Ensure width and height in InteractiveMap are integers (OSGeo#4221

r3.showdspf: fix null pointer dereference when opening database file (OSGeo#4245

r3.showdspf: fix accessing uninitialized pointer (https://github.com/OSGeo/grass/pull/4246[)](https://github.com/a0x8o/grass/commit/b61c61d1a5c7ef07891a4819af7eadf7024228bd)

init: Use pathlib Path.write_text for writefile in the main executable (

CI(deps): Update github/codeql-action action to v3.26.6 (https://github.com/OSGeo/grass/pull/4248[)](https://github.com/a0x8o/grass/commit/275cc4b4e4cb0a3def52aa80ba916a37fbe1c43f)

grass.jupyter: Clarify InteractiveMap documentation (https://github.com/OSGeo/grass/pull/4243[)](https://github.com/a0x8o/grass/commit/04b5af77e1a25300d793e116e2a5724d7a320c41)

CI(deps): Update actions/setup-python action to v5.2.0 (https://github.com/OSGeo/grass/pull/4250[)](https://github.com/a0x8o/grass/commit/591dc1959c1aa586ef1d2b3fa97a84847e098014)

CI(deps): Update ruff to v0.6.3 (https://github.com/OSGeo/grass/pull/4252[)](https://github.com/a0x8o/grass/commit/eeb0e0295373294c9ea0d023f01578f9defb05cf)

grass.temporal.stds_import: Use pathlib Path.read_text and Path.write…

v.external.out: Check for valid array before passing it to qsort (OSGeo#4251

GUI: fix verbose checkbox behavior in tool dialogs (https://github.com/OSGeo/grass/pull/4257[)](https://github.com/a0x8o/grass/commit/52964a530f9602ad7e62e9832da45dfc83238f86)

lib/display: D_show_conversions() %.1f to %g where values likely to b…

CI(deps): Lock file maintenance (https://github.com/OSGeo/grass/pull/4266[)](https://github.com/a0x8o/grass/commit/06612120879cca0a1a3d2401ddd9f5e9471a4bf3)

docker: fix missing libraries in ubuntu wxgui Dockerfile (https://github.com/OSGeo/grass/pull/4268[)](https://github.com/a0x8o/grass/commit/fa37eb2ca38d5b1c9994168869217f2092b5736c)

CI(deps): Update actions/upload-artifact action to v4.4.0 (https://github.com/OSGeo/grass/pull/4259[)](https://github.com/a0x8o/grass/commit/42b47f295a47f6dbe609fe464d7ea4bafc2650fc)

CI(deps): Update peter-evans/create-pull-request action to v7 (OSGeo#4269

lib: deprecate G_snprintf() and replace with C99 snprintf() (https://github.com/OSGeo/grass/pull/4189[)](https://github.com/a0x8o/grass/commit/9222822ae60ae327d09c07ee9c40053762e4b7a3)

r.in.gdal/r.external: add basic support for GDALs GDT_Int8 (https://github.com/OSGeo/grass/pull/4256[)](https://github.com/a0x8o/grass/commit/66389f0ba80af1de97aeced1c86c76f15e132fd4)

checks: Flake8 F841 fixes in the wxpython directory part 2 (https://github.com/OSGeo/grass/pull/4253[)](https://github.com/a0x8o/grass/commit/e132155a73521dbb24f98d954d7b04bf9743c518)

CI(deps): Update DoozyX/clang-format-lint-action action to v0.18.2 (OSGeo#4274

petrasovaa and others added 28 commits August 26, 2024 16:31
Also exclude MD041 globally
…d_text() (#4233)

Reads the whole file using a context manager internally.
Bug introduced in 02e45e9 when trying to avoid calling complete tree refresh every time.
Update locdownload.py with link to latest natural earth sample dataset
* docs: add guidelines for writing a meaningful pull request

A well-written pull request (PR) is critical because it not only improves collaboration and efficiency within a project but also helps newcomers to contribute more easily.

Fixes #4194

* shorten intro text; add link to release.yml

* reduce 'PR Content' description

* add link to PR template

---------

Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
…4245)

r3.showdspf: fix null pointer dereference

In the current execution, when we face an error while trying
to open a database file, as part of error log we are dereferencing
a NULL file pointer (which is returend when we try to open a file).
Ideally we should be printing the name of the database file rather
than the file pointer. This fixes the problem of null pointer
dereference. Found via cppcheck tool.

Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
color2 pointer is not initialized and it is assigned a value
depending on a conditional. Potentially, in an execution path
if conditional fails, we would be accessing an uninitialized
pointer, whose behavior is undefined. Initialize the pointer
to NULL to avoid this.

Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
Clarify using different backends
Fix icons
Currently, if 'HAVE_OGR' macro is defined, as part of execution, we sort all formats by name using qsort. But, array containing all formats is assigned based on a conditional and if the conditional fails, it can be NULL.

Behavior of qsort when a NULL array is provided is undefined. To avoid getting into that situation, check if the array is NULL before performing qsort on it.

Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
…e smaller than 0.0 (#4263)

Display pixels or raster region rows,cols are likely be on the order of 500, while projected map units are often in the millions, so pixels/meter factor can end up as a very small number. This patch edits an unused in the production code debug helper function to not round that division into a confusing 0.0, as well as some whitespace tweaks to make it more readable.
* docker: fix missing library in ubuntu wxgui Dockerfile

Add `libgtk-3-dev` to fix

```
...
checking for GTK+ - version >= 3.0.0... Package gtk+-3.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-3.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-3.0' found
```

* also install 'python3-wxgtk4.0'
* lib: deprecate G_snprintf() and replace with C99 snprintf()

Beginning with UCRT in Visual Studio 2015 and Windows 10, the behaviour of snprintf (and vsnprintf) is now C99 standard conformant.

Thus, the output is now always null-terminated. The justification for a internal fix for that is no longer needed.

* r3.out.bin: fix -Werror=sizeof-pointer-memaccess GCC warning

* cast explicitly

* add missing #include
* add support for Int8 from GDAL >= 3.7

* add int8 test (skiped if GDAL < 3.7)
@a0x8o a0x8o merged commit 98f38fc into a0x8o:main Sep 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.