init: Use pathlib Path.read_text for readfile in the main executable

[echoix]

I explicitly don't want readfile and writefile to be changed in the same PR.
I don't see any coverage (pytest from here, nor gunittest from my fork (too slow to be used allways)), that runs into the init script. So the approach is to leave it for some time before changing.

The readfile function is only used inside that file, 10 references, in functions like create_gisrc(), set_mapset(), load_env(), csh_startup(), sh_like_startup(), classic_parser().

If it were to have an impact, we should see it easily.

I seriously don't think there are any difference, as Pathlib's read_text() function is really simple to understand, so I'm including it here for reference when reviewing my similar PRs:

    def read_text(self, encoding=None, errors=None, newline=None):
        """
        Open the file in text mode, read it, and close the file.
        """
        # Call io.text_encoding() here to ensure any warning is raised at an
        # appropriate stack level.
        encoding = io.text_encoding(encoding)
        return PathBase.read_text(self, encoding, errors, newline)

https://github.com/python/cpython/blob/fe85a8291d9aa11c9ce9e207c39ea0a0c35f9625/Lib/pathlib/_local.py#L591-L598

calling

    def read_text(self, encoding=None, errors=None, newline=None):
        """
        Open the file in text mode, read it, and close the file.
        """
        with self.open(mode='r', encoding=encoding, errors=errors, newline=newline) as f:
            return f.read()

https://github.com/python/cpython/blob/fe85a8291d9aa11c9ce9e207c39ea0a0c35f9625/Lib/pathlib/_abc.py#L736-L741

and write_text() (not used here):

    def write_text(self, data, encoding=None, errors=None, newline=None):
        """
        Open the file in text mode, write to it, and close the file.
        """
        # Call io.text_encoding() here to ensure any warning is raised at an
        # appropriate stack level.
        encoding = io.text_encoding(encoding)
        return PathBase.write_text(self, data, encoding, errors, newline)

https://github.com/python/cpython/blob/fe85a8291d9aa11c9ce9e207c39ea0a0c35f9625/Lib/pathlib/_local.py#L600-L607

calling

    def write_text(self, data, encoding=None, errors=None, newline=None):
        """
        Open the file in text mode, write to it, and close the file.
        """
        if not isinstance(data, str):
            raise TypeError('data must be str, not %s' %
                            data.__class__.__name__)
        with self.open(mode='w', encoding=encoding, errors=errors, newline=newline) as f:
            return f.write(data)

https://github.com/python/cpython/blob/fe85a8291d9aa11c9ce9e207c39ea0a0c35f9625/Lib/pathlib/_abc.py#L752-L760

[wenzeslaus]

I agree, if this is broken we will know quickly.

[echoix]

@veroandreo I was wondering if you were using this week a build from main since this was merged. I was waiting for the end of the week before merging #4235, to see if anything would pop up.

[veroandreo]

@veroandreo I was wondering if you were using this week a build from main since this was merged. I was waiting for the end of the week before merging #4235, to see if anything would pop up.

I am using main indeed, and I just recompiled this morning. What should I test?

[echoix]

Just opening and starting grass. It touched reading bash profiles. If it was broken you should've noticed it already.

[veroandreo]

Just opening and starting grass. It touched reading bash profiles. If it was broken you should've noticed it already.

no, no issues

[echoix]

Just opening and starting grass. It touched reading bash profiles. If it was broken you should've noticed it already.

no, no issues

Great! We might as well proceed earlier with #4235, it only needs a new approval after fixing the intended merge conflict when this PR was merged cleared the approval.