r3.showdspf: fix null pointer dereference when opening database file #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference. Found via cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
lbartoletti
approved these changes
Aug 29, 2024
marisn
approved these changes
Aug 29, 2024
ShubhamDesai
pushed a commit
to ShubhamDesai/grass
that referenced
this pull request
Aug 29, 2024
…SGeo#4245) r3.showdspf: fix null pointer dereference In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference. Found via cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Sep 5, 2024
…SGeo#4245) r3.showdspf: fix null pointer dereference In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference. Found via cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
…SGeo#4245) r3.showdspf: fix null pointer dereference In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference. Found via cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file and error out). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference.
This issue was found using cppcheck tool.
Output from cppcheck tool:
Output from cppcheck with the fix applied: