gui: Add fix for wxGUI Data import Python error #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes OSGeo#648 by adding a command tracker queue. When the queue is not empty, closing the dialog is prevented to ensure the completion callback can still access UI elements.
ww2406
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Great to see some progress on an older issue! |
neteler
changed the title
|
@ww2406 thank you for looking into this. I think this makes sense, I will leave just couple notes below. |
petrasovaa
reviewed
Oct 14, 2024
petrasovaa
reviewed
Oct 14, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks for the notes, @petrasovaa! I think I've got everything taken care of. Is there anything else needed from me at all? |
petrasovaa
approved these changes
Oct 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #648 by adding a command tracker queue.
Currently, a user can trigger an error if they manually close the dialog box before the commands. This is due to the command completion callbacks depending on state from the UI dialog which is not accessible if the dialog is destroyed.
To address this, I added a command tracking queue to keep track of the number of commands executing. This PR then modifies the close event handler so that If this queue is not empty, the close command is interrupted and does not execute.
One opportunity might be to consolidate the command dispatch mechanism into one function so future maintainers do not need to explicitly invoke the proposed
_addToCommandQueuefunction, but I wasn't sure if that was optimizing more than needed at the moment.Look forward to any feedback you might have!