F841 fixes #18
Merged
F841 fixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes locales in nix provided development environment by setting environment variable. Closes #4503
This PR adds an overview text to imageryintro.html including a link to addons. (aside, addons URL fix in g.gui.gmodeler.html) Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com> Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
As epsg.io is partially outdated (see [source](maptiler/epsg.io#171) and related) and PROJ is our engine anyway, this PR switches the references in the GUI to https://spatialreference.org. * "See also" section: added URLs to CRS Explorer and EPSG Geodetic Parameter Dataset Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
* CI(deps): Update ruff to v0.7.0 * style: Fix FURB156: Use of hardcoded string charset --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
* i.atcorr: fix out of bound access in trunca, os and iso In trunca(), under 2 if conditionals (if rumu[1] > 0.8 and rmu[1] > 0.94), k and kk values are set to -1 respectively. When these values are used to access an array, it leads to out of bound access, which is undefined behavior in c++. Similarly in os() and iso(), if `taup < h[i]` for all values, iplane would still be -1 and we would be accessing an array with this as an index, which is undefined behavior. In both cases, to avoid that, set that index to zero. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> * Update imagery/i.atcorr/computations.cpp When plane layer couldn't be determined, throw out an error and exit. Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com> * Update imagery/i.atcorr/computations.cpp When plane layer couldn't be determined, throw out an error and exit. Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com> * Fix clang-format issues Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> --------- Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com> Co-authored-by: Markus Metz <33666869+metzm@users.noreply.github.com>
…4523) * t.rast.accumulate: Call t.remove with multiple inputs in test_accumulation * t.rast.accdetect: Call t.remove with multiple inputs * t.rast.univar: Call t.remove once with multiple inputs * tests: Call g.remove once with multiple names to remove One call per type, when all other arguments are the same * benchmark: Call g.remove once with multiple names to remove One call per type, when all other arguments are the same * utils/thumbnails: Call g.remove once with multiple names to remove * Use tuple for supplying multiple input maps
This fixes #648 by adding a command tracker queue. When the queue is not empty, closing the dialog is prevented to ensure the completion callback can still access UI elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxGUI: Fixed F841 in mapwindow.py (https://github.com/OSGeo/grass/pull/4538[)](https://github.com/a0x8o/grass/commit/39ff021208e8cbca0615c3545ffa9d191e149e88)
wxGUI: Added TypeError to lmgr/ (https://github.com/OSGeo/grass/pull/4537[)](https://github.com/a0x8o/grass/commit/a740da1d4a638c0e129ac95e7c298961f06f3111)
wxGUI: Fixed F841 in modules/ (https://github.com/OSGeo/grass/pull/4528[)](https://github.com/a0x8o/grass/commit/4e8b0bf5e890f398b528f630c112b86b5a6d9471)
GUI: fix crashing due to File menu translation issues (https://github.com/OSGeo/grass/pull/4513[)](https://github.com/a0x8o/grass/commit/941b52f87c44e6f19b3be960553d37deb7c0f1e8)
wxGUI: Fixed F841 in tools.py (https://github.com/OSGeo/grass/pull/4539[)](https://github.com/a0x8o/grass/commit/fd347b9e837a6903d1f917bd56edd3aa8a9995ba)
wxGUI: Fixed F405 in psmap/ (https://github.com/OSGeo/grass/pull/4541[)](https://github.com/a0x8o/grass/commit/daee9896da48bced7d59cfb998952f7ff6e2245b)
wxGUI: Fixed unused variable F841 (https://github.com/OSGeo/grass/pull/4542[)](https://github.com/a0x8o/grass/commit/0adc4dc2ec42e07c82012fb948b0b9cac4b4afb3)
nix: Fix locales in development environment (https://github.com/OSGeo/grass/pull/4540[)](https://github.com/a0x8o/grass/commit/e540efc76618837947fefca21d8b141913ff6376)
docs: add intro text to imageryintro.html (https://github.com/OSGeo/grass/pull/4536[)](https://github.com/a0x8o/grass/commit/9dbc8c96b05eaff6df9dc2ffd55c7e8f45fa25e9)
GUI: EPSG code source: replace epsg.io with spatialreference.org (OSGeo#4535
CI(deps): Update ruff to v0.7.0 (https://github.com/OSGeo/grass/pull/4544[)](https://github.com/a0x8o/grass/commit/3c678251df9b4dbe30c6cef2f075eeea18efa1df)
renovate[bot] and echoix authored 14 hours ago
i.atcorr: fix out of bound access in trunca, os and iso (https://github.com/OSGeo/grass/pull/4493[)](https://github.com/a0x8o/grass/commit/d788eee193b3e3a4d10194775cec9d4429802403)
wxGUI: Fixed F841 in vnet/ (https://github.com/OSGeo/grass/pull/4543[)](https://github.com/a0x8o/grass/commit/0cb20eb612b933dc914461f6c541510213bc71e0)
tests: Call t.remove and g.remove once with multiple inputs as list (OSGeo#4523
gui: Add fix for wxGUI Data import Python error (https://github.com/OSGeo/grass/pull/4504[)](https://github.com/a0x8o/grass/commit/62b001b1318fb331334d6a9bab3ec0f6fba60360)