Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fixed F841 in modules/ #4528

Merged
merged 4 commits into from
Oct 17, 2024
Merged

wxGUI: Fixed F841 in modules/ #4528

merged 4 commits into from
Oct 17, 2024

Conversation

arohanajit
Copy link
Contributor

Fixed all F841 errors in modules/

  • removed point, ext and geometry variable which were not being used
  • called the App() constructor directly
  • One issue that popped up was while running pre-commit on import_export.py, This error constantly popped up in ruff checks
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

gui/wxpython/modules/import_export.py:615:30: F823 Local variable `_` referenced before assignment
    |
614 |         if not data:
615 |             GMessage(message=_("No layers selected. Operation canceled."), parent=self)
    |                              ^ F823
616 |             return
    |

Found 1 error.

I didn't find a fix for it currently so I just referenced the _ locally in the function

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Oct 15, 2024
@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 17, 2024
@petrasovaa petrasovaa merged commit 4e8b0bf into OSGeo:main Oct 17, 2024
26 checks passed
@a0x8o a0x8o mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants