-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Custom Gitlab Instance #965
Conversation
Signed-off-by: Kainan(Kris) Zhang <4xpl0r3r@gmail.com>
This is my example of env file GITLAB_CLIENT_ID=0000000000000000000000000000000
GITLAB_CLIENT_SECRET=gloas-0000000000000000000000000000000
GITLAB_SCOPE=read_user read_repository write_repository profile read_api api
GITLAB_REDIRECT_URI=http://threat-dragon-instance/api/oauth/return
GITLAB_HOST=http://gitlab-instance |
#947 Ref |
apologies for being slow to review this @4xpl0r3r , the pull request is much appreciated and I hope to look at it this weekend |
Don’t mind, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4xpl0r3r I thought we needed the env variables 'ENTERPRISE_HOSTNAME', 'ENTERPRISE_PROTOCOL' and 'ENTERPRISE_PORT' for running gitlab enterprise?
This is being discussed in #947 if I understand correctly @steve-winter and @fdellwing ?
I believe we should merge
Just my personal understanding, it is ok to keep the original names in case there is any concern I missed. |
I totally missed this PR, so sorry for the late response and thanks for the ping. I tested the PR and it seems to work fine. I'm in support of merging the 3 keys into |
OK, thanks @fdellwing and @4xpl0r3r I will go ahead and merge |
Summary:
This PR makes the code supporting custom Gitlab instance, merged 3
GITLAB_ENTERPRISE_*
configs into 1GITLAB_HOST
.Description for the changelog:
GITLAB_ENTERPRISE_*
configs into 1GITLAB_HOST
.host
parameter for GitlabclientOptions
to support custom Gitlab instances.Other info:
I have tested the code, it works well with my community edition gitlab instance. It seems like the config names
GITLAB_ENTERPRISE_*
, which are similar to the Github's, are not proper names for Gitlab because there could be both community edition and enterprise edition of custom Gitlab. Therefore, I merged these 3 configs into 1GITLAB_HOST
.Have a nice day.