Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for gitlab #91

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Add guide for gitlab #91

merged 4 commits into from
Jul 8, 2024

Conversation

4xpl0r3r
Copy link
Collaborator

@4xpl0r3r 4xpl0r3r commented Jun 29, 2024

Summary:
Ref: OWASP/threat-dragon#965 and #82

This is to add the guide of settting of GitLab access

closes #81

@jgadsden jgadsden self-requested a review June 29, 2024 21:09
@jgadsden jgadsden added the documentation Improvements or additions to documentation label Jun 29, 2024
@fdellwing
Copy link
Collaborator

From my testing it is actually enough to just use the api scope because it contains all permissions.

@jgadsden jgadsden added the enhancement New feature or request label Jul 8, 2024
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for not reviewing this earlier @4xpl0r3r , lots of pieces to pick up after OWASP Lisbon conference :)
Could you delete the trailing space on line 34? It keeps lint happy

@fdellwing could you expand on your review? Are you saying that the scopes can be just api and do not have to be read_user read_repository write_repository profile read_api api

@jgadsden
Copy link
Collaborator

jgadsden commented Jul 8, 2024

If you can add these words to the .wordlist.txt file that will keep the spellchecker happy:

  • configs
  • URI
  • BaseURL

@fdellwing
Copy link
Collaborator

Are you saying that the scopes can be just api and do not have to be read_user read_repository write_repository profile read_api api

I was not able to get the integration to work with just read_user read_repository write_repository profile read_api, I needed to give api. And as api contains all other scopes, they can be omitted.

@jgadsden jgadsden merged commit d0ab1a7 into OWASP:main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add step by step for gitlab access
3 participants