remove constructor from aeERC20
#98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
requested changes
Dec 18, 2024
| @@ -27,11 +27,6 @@ import "./TransferAndCallToken.sol"; | |||
| contract aeERC20 is ERC20PermitUpgradeable, TransferAndCallToken { | |||
| using AddressUpgradeable for address; | |||
|
|
|||
| constructor() initializer { | |||
There was a problem hiding this comment.
if this is removed, the logic contract would become initializable
while I don't think it will causes any problem in our usecase especially when self-destruct no longer delete code, it is something we should think about; in L2AtomicTokenBridgeFactory we call initialize on the logic contract (which should not be callable if it were deployed normally because of the constructor) deployed by CreationCodeHelper trick to prevent those logic from being re-inited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the empty constructor in
aeERC20can cause issues with explorer verification because the built constructor code differs from the code used byCreationCodeHelper