Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove constructor from aeERC20 #98

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove constructor from aeERC20 #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions contracts/tokenbridge/libraries/aeERC20.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ import "./TransferAndCallToken.sol";
contract aeERC20 is ERC20PermitUpgradeable, TransferAndCallToken {
using AddressUpgradeable for address;

constructor() initializer {
Copy link
Member

@gzeoneth gzeoneth Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is removed, the logic contract would become initializable
while I don't think it will causes any problem in our usecase especially when self-destruct no longer delete code, it is something we should think about; in L2AtomicTokenBridgeFactory we call initialize on the logic contract (which should not be callable if it were deployed normally because of the constructor) deployed by CreationCodeHelper trick to prevent those logic from being re-inited

// this is expected to be used as the logic contract behind a proxy
// override the constructor if you don't wish to use the initialize method
}

function _initialize(
string memory name_,
string memory symbol_,
Expand Down
Loading